Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 037843ae12ffcf5071691e3a0ded328179b37a6e
https://github.com/WebKit/WebKit/commit/037843ae12ffcf5071691e3a0ded328179b37a6e
Author: Youenn Fablet <[email protected]>
Date: 2026-08-25 (Tue, 25 Aug 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer_interop-2026-expected.txt
M Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
M Source/WebCore/Modules/mediastream/RTCPeerConnection.h
Log Message:
-----------
Validate fingerprints to previous generated offer/answer when apply a local
description
rdar://183719203
https://bugs.webkit.org/show_bug.cgi?id=320733
Reviewed by Eric Carlson.
We update setLocalDescription for the non parameter less setLocalDescription.
To validate that applied description comes from the previous generated
offer/answer, we validate the fingerprints.
We do not go as far as validating the whole SDP since SDP munging is still a
thing.
We also stop resetting last offer/answer in
RTCPeerConnection::updateDescriptions as this is not as per spec.
To not change the parameterless setLocalDescription behavior, we introduce
booleans to control how much we reuse the last offer/answer.
Covered by rebased tests.
*
LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer_interop-2026-expected.txt:
* Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::createAnswer):
(WebCore::typeForSetLocalDescription):
(WebCore::isSdpFingerprintValid):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore::RTCPeerConnection::updateDescriptions):
* Source/WebCore/Modules/mediastream/RTCPeerConnection.h:
Canonical link: https://commits.webkit.org/319822@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
