Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a6dae4543addea4b067213bcc54e60e62bdf665d
https://github.com/WebKit/WebKit/commit/a6dae4543addea4b067213bcc54e60e62bdf665d
Author: Claudio Saavedra <[email protected]>
Date: 2026-08-26 (Wed, 26 Aug 2026)
Changed paths:
M LayoutTests/ipc/serialized-type-info.html
Log Message:
-----------
ipc/serialized-type-info.html reports the wrong types off Cocoa
https://bugs.webkit.org/show_bug.cgi?id=322570
Reviewed by Alex Christensen.
expectedTypesNeedingDescriptions() was written when Cocoa was the only port
running this test, so five of its entries get pushed where the types do not
exist: CTFontDescriptorOptions and MachSendRight were unconditional, and
NSObject<NSSecureCoding>, NSURLRequest and DDScannerResult are gated on
HAVE(WK_SECURE_CODING_*), which is false off Cocoa. Gate all five on
isMac || isIOSFamily, which covers the whole family including visionOS.
WebCore::ContextMenuAction is the other way round. It was gated on isMac, but it
is an unscoped enum reached from the cross-platform
Shared/WebContextMenuItemData.serialization.in, which is guarded by
ENABLE(CONTEXT_MENUS): on by default and off only on PLATFORM(IOS_FAMILY). Key
it
on !isIOSFamily so it is expected wherever the type is serialized.
Finally, WebCore::SystemImage has three subclasses and all of them are
Cocoa-only,
so off Cocoa its subclasses member is generated as Variant<>.
splitTypeFromList()
returned the empty string for that, which the test reported as a type without a
description. Return no types for an empty template argument list.
The expected set is unchanged on macOS, iOS and visionOS for every combination
of
the two secure-coding predicates.
* LayoutTests/ipc/serialized-type-info.html:
Canonical link: https://commits.webkit.org/319886@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
