Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f391e2248bba0cd065ec18899cbc0f64725a955f
https://github.com/WebKit/WebKit/commit/f391e2248bba0cd065ec18899cbc0f64725a955f
Author: Issac Roy <[email protected]>
Date: 2026-08-26 (Wed, 26 Aug 2026)
Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[EWS] Flaky Detection Fixes
https://bugs.webkit.org/show_bug.cgi?id=322607
rdar://185912043
Reviewed by Aakash Jain.
GTK/WPE need to fall back to `webkit_version` when there is no
`os_version`.
`SiteIsolationResultsDBMixin` suppresses reporting because the site-isolation
queue used to blame a change after a single test run, so there was no
confirmed outcome worth recording. 319404@main gave the queue the same retry
ladder as every other layout-test queue so we should add it to the system.
Layout-test steps derive the results-database flavor from
`layout_test_driver`, but only `RunWebKit1Tests` and
`RunWebKitTestsInStressMode` ever set that attribute, and the stress step
runs only when the change modified layout tests. Replace the derivation
with a `results_db_flavor` class attribute, since the subclass is the
label. `None` means "leave the label the first run set", which the reruns
need.
* Tools/CISupport/ews-build/steps.py:
(ResultsDBReportMixin.results_db_query_configuration):
(ResultsDBReportMixin.results_db_configuration):
(RunWebKitTests):
(RunWebKitTests.run):
(RunWebKitTestsInStressMode):
(ReRunWebKitTests):
(RunWebKitTestsWithoutChange):
(SiteIsolationResultsDBMixin):
(RunWebKit1Tests):
(SiteIsolationResultsDBMixin.results_db_query_configuration): Deleted.
* Tools/CISupport/ews-build/steps_unittest.py:
(test_the_run_labels_the_build_wk2):
(test_the_rerun_leaves_the_label_the_first_run_set):
(TestRunWebKitTestsInStressMode):
(TestRunWebKitTestsInStressMode.test_stress_mode_does_not_label_the_build):
(TestRunWebKitTestsEWSSiteIsolation):
(TestRunWebKitTestsEWSSiteIsolation.test_the_run_labels_the_build_site_isolation):
(TestReRunWebKitTestsEWSSiteIsolation):
(TestReRunWebKitTestsEWSSiteIsolation.test_the_rerun_keeps_the_site_isolation_label):
(TestRunWebKit1Tests):
(TestRunWebKit1Tests.test_the_run_labels_the_build_wk1):
(TestFilterLayoutTestFailuresUsingResultsDB.test_site_isolation_queries_keep_their_platform):
(TestReportToResultsDB.test_a_glib_port_reports_the_webkit_version_it_builds):
(TestRunWebKitTestsEWSSiteIsolation.test_results_db_query_configuration_uses_site_isolation_flavor):
Deleted.
(TestReRunWebKitTestsEWSSiteIsolation.test_results_db_query_configuration_uses_site_isolation_flavor):
Deleted.
(TestFilterLayoutTestFailuresUsingResultsDB.test_site_isolation_queries_across_platforms):
Deleted.
Canonical link: https://commits.webkit.org/319902@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
