Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0ba64924f939b269a8acda143660ea80eec4161e
      
https://github.com/WebKit/WebKit/commit/0ba64924f939b269a8acda143660ea80eec4161e
  Author: Kiet Ho <[email protected]>
  Date:   2026-08-26 (Wed, 26 Aug 2026)

  Changed paths:
    A LayoutTests/css3/supports-at-rule-when-feature-flag-disabled-expected.txt
    A LayoutTests/css3/supports-at-rule-when-feature-flag-disabled.html
    M Source/WebCore/css/parser/CSSSupportsParser.cpp

  Log Message:
  -----------
  [css-conditional-5] @supports at-rule should check whether an at-rule is 
enabled via feature flags
rdar://184664687
https://bugs.webkit.org/show_bug.cgi?id=321556

Reviewed by Tim Nguyen and Antti Koivisto.

@supports at-rule() doesn't take into account when an at-rule is controlled by
a feature flag. For example, @function is controlled by 
CSSFunctionAtRuleEnabled,
so it's only supported when CSSFunctionAtRuleEnabled is enabled, but
`@supports at-rule(@function)` returns true at all time.

Fix it so that @supports at-rule() consults the feature flag if an at-rule is
controlled by one.

Test: css3/supports-at-rule-when-feature-flag-disabled.html

* LayoutTests/css3/supports-at-rule-when-feature-flag-disabled-expected.txt: 
Added.
* LayoutTests/css3/supports-at-rule-when-feature-flag-disabled.html: Added.
* Source/WebCore/css/parser/CSSSupportsParser.cpp:
(WebCore::CSSSupportsParser::consumeSupportsAtRuleFunction):

Canonical link: https://commits.webkit.org/319936@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to