Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 82407cd47dd16a25b04dbc974c520566ef171480
https://github.com/WebKit/WebKit/commit/82407cd47dd16a25b04dbc974c520566ef171480
Author: Sam Sneddon <[email protected]>
Date: 2026-08-27 (Thu, 27 Aug 2026)
Changed paths:
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py
M
Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/autoinstall_unittest.py
Log Message:
-----------
Package.is_cached() should use exact version matching
https://bugs.webkit.org/show_bug.cgi?id=320507
rdar://183470357
Reviewed by Ryan Haddad.
259248@main fixed this bug in Package.archives(), switching from
Version's __contains__ prefix matching to an exact one, but left
Package.is_cached() comparing the cached manifest version with
__contains__. A manifest cached under a looser pin (or from before
259248@main) can therefore still read as up to date even though it
isn't an exact match. Switch is_cached() to the same exact-match
comparison, so such a manifest is correctly treated as stale and
reinstalled.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(Package.is_cached): Use != instead of not in for the version comparison.
*
Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/autoinstall_unittest.py:
(IsCachedTest):
(IsCachedTest.setUp):
(IsCachedTest.test_is_cached_rejects_loose_version_match):
(IsCachedTest.test_is_cached_accepts_exact_version_match):
Canonical link: https://commits.webkit.org/320006@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
