Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 585cb45609b37a90566b0b114c25043c7f3f6680
https://github.com/WebKit/WebKit/commit/585cb45609b37a90566b0b114c25043c7f3f6680
Author: Dominic Mazzoni <[email protected]>
Date: 2026-08-27 (Thu, 27 Aug 2026)
Changed paths:
A
LayoutTests/accessibility/isolated-tree/mac/text-marker-range-for-text-control-expected.txt
A
LayoutTests/accessibility/isolated-tree/mac/text-marker-range-for-text-control.html
A
LayoutTests/accessibility/mac/text-marker-range-for-text-control-expected.txt
A LayoutTests/accessibility/mac/text-marker-range-for-text-control.html
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.h
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilityObjectInlines.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
Log Message:
-----------
AX: AXTextMarkerRangeForUIElement covers a native text control as a replaced
object rather than its value
https://bugs.webkit.org/show_bug.cgi?id=322688
rdar://185960907
Reviewed by Tyler Wilcock.
On the live AX tree, asking for a <textarea>'s or <input type=text>'s
text marker range was giving back a range whose string was a single object
replacement character (U+FFFC) and whose endpoints carried no useful
index. This doesn't match the isolated tree, which returns a useful
range derived from its shadow tree.
textMarkerRange() now descends into the inner text element for native text
controls, leaving out the trailing placeholder <br> to match other APIs
like AXNumberOfCharacters.
A special case is needed for a control with no value.
Tests: accessibility/isolated-tree/mac/text-marker-range-for-text-control.html
accessibility/mac/text-marker-range-for-text-control.html
*
LayoutTests/accessibility/isolated-tree/mac/text-marker-range-for-text-control-expected.txt:
Added.
*
LayoutTests/accessibility/isolated-tree/mac/text-marker-range-for-text-control.html:
Added.
*
LayoutTests/accessibility/mac/text-marker-range-for-text-control-expected.txt:
Added.
* LayoutTests/accessibility/mac/text-marker-range-for-text-control.html: Added.
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isNativeTextControl const): Deleted.
(WebCore::AccessibilityNodeObject::text const):
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::nativeTextControl const):
(WebCore::AccessibilityObject::textMarkerRange const):
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isNativeTextControl const):
* Source/WebCore/accessibility/AccessibilityObjectInlines.h:
(WebCore::AccessibilityObject::textMarkerRange const): Deleted.
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):
Canonical link: https://commits.webkit.org/320011@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
