Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f54d0579631ecf491974f33c46fcae9e47cee8bc
https://github.com/WebKit/WebKit/commit/f54d0579631ecf491974f33c46fcae9e47cee8bc
Author: Antoine Quint <[email protected]>
Date: 2026-08-28 (Fri, 28 Aug 2026)
Changed paths:
M Source/WebCore/animation/CSSAnimation.cpp
M Source/WebCore/animation/ScrollTimeline.cpp
M Source/WebCore/animation/ScrollTimeline.h
M Source/WebCore/animation/StyleOriginatedTimelinesController.cpp
M Source/WebCore/animation/StyleOriginatedTimelinesController.h
M Source/WebCore/animation/ViewTimeline.cpp
M Source/WebCore/animation/ViewTimeline.h
M Source/WebCore/style/Styleable.cpp
M Source/WebCore/style/values/animations/StyleSingleAnimationTimeline.cpp
M Source/WebCore/style/values/animations/StyleSingleAnimationTimeline.h
M Source/WebCore/style/values/scroll-animations/StyleProgressTimelineName.h
Log Message:
-----------
[scroll-animations] keep track of style scope for `animation-timeline` and
`{scroll|view}-timeline-name` properties
https://bugs.webkit.org/show_bug.cgi?id=322739
rdar://186008235
Reviewed by Anne van Kesteren.
Track the style scope when parsing the `animation-timeline`,
`scroll-timeline-name` and
`view-timeline-name` properties such that in a future patch we may correctly
look up
progress-based timelines across style scopes and address bug 322013.
We simply change `Style::CustomIdent` to `Style::ScopedName` in
`Style::SingleAnimationTimeline`
and `Style::ProgressTimelineName` and additionally switch from `AtomString` to
`Style::ScopedName`
to represent a progress-based timeline's name.
* Source/WebCore/animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::syncStyleOriginatedTimeline):
* Source/WebCore/animation/ScrollTimeline.cpp:
(WebCore::ScrollTimeline::create):
(WebCore::ScrollTimeline::createInactiveStyleOriginatedTimeline):
(WebCore::ScrollTimeline::ScrollTimeline):
(WebCore::ScrollTimeline::matchesAnonymousScrollFunctionForSource const):
* Source/WebCore/animation/ScrollTimeline.h:
(WebCore::ScrollTimeline::setName):
* Source/WebCore/animation/StyleOriginatedTimelinesController.cpp:
(WebCore::StyleOriginatedTimelinesController::registerNamedScrollTimeline):
(WebCore::StyleOriginatedTimelinesController::updateCSSAnimationsAssociatedWithNamedTimeline):
(WebCore::StyleOriginatedTimelinesController::registerNamedViewTimeline):
(WebCore::StyleOriginatedTimelinesController::attachAnimation):
(WebCore::StyleOriginatedTimelinesController::updateNamedTimelineMapForTimelineScope):
* Source/WebCore/animation/StyleOriginatedTimelinesController.h:
* Source/WebCore/animation/ViewTimeline.cpp:
(WebCore::ViewTimeline::create):
(WebCore::ViewTimeline::ViewTimeline):
(WebCore::ViewTimeline::matchesAnonymousViewFunctionForSubject const):
* Source/WebCore/animation/ViewTimeline.h:
* Source/WebCore/style/Styleable.cpp:
(WebCore::Styleable::updateCSSScrollTimelines const):
(WebCore::Styleable::updateCSSViewTimelines const):
* Source/WebCore/style/values/animations/StyleSingleAnimationTimeline.cpp:
(WebCore::Style::CSSValueConversion<SingleAnimationTimeline>::operator):
* Source/WebCore/style/values/animations/StyleSingleAnimationTimeline.h:
(WebCore::Style::SingleAnimationTimeline::SingleAnimationTimeline):
(WebCore::Style::SingleAnimationTimeline::isScopedName const):
(WebCore::Style::SingleAnimationTimeline::tryScopedName const):
(WebCore::Style::SingleAnimationTimeline::isCustomIdent const): Deleted.
(WebCore::Style::SingleAnimationTimeline::tryCustomIdent const): Deleted.
* Source/WebCore/style/values/scroll-animations/StyleProgressTimelineName.h:
Canonical link: https://commits.webkit.org/320026@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
