Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d2fe653739140d3679933ef7b5a42561b95e53e8
https://github.com/WebKit/WebKit/commit/d2fe653739140d3679933ef7b5a42561b95e53e8
Author: Devin Rousso <[email protected]>
Date: 2026-08-31 (Mon, 31 Aug 2026)
Changed paths:
M
LayoutTests/http/tests/websocket/tests/hybi/inspector/before-load-expected.txt
M LayoutTests/http/tests/websocket/tests/hybi/inspector/before-load.html
M Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.h
M Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.mm
Log Message:
-----------
Web Inspector: `WebSocket` handshake headers are missing using
`Network.framework` loader
https://bugs.webkit.org/show_bug.cgi?id=321547
Reviewed by Youenn Fablet.
`NSURLSessionWebSocketTask.currentRequest` can omit WebSocket handshake headers
added by the loader, even though those headers are sent over the network.
* Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.h:
* Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.mm:
(WebKit::WebSocketTask::WebSocketTask):
(WebKit::WebSocketTask::readNextMessage):
(WebKit::WebSocketTask::reportHandshakeRequest): Added.
(WebKit::WebSocketTask::didConnect):
(WebKit::WebSocketTask::didClose):
Defer reporting the handshake request until the connection opens/fails as
that's when transaction metrics are available.
Use the request from the most recent transaction, falling back to
`currentRequest` when unavailable.
* LayoutTests/http/tests/websocket/tests/hybi/inspector/before-load.html:
*
LayoutTests/http/tests/websocket/tests/hybi/inspector/before-load-expected.txt:
Canonical link: https://commits.webkit.org/320156@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
