Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 070356a60a77ee878b21ce8c9d2dda7a3d1c4257
https://github.com/WebKit/WebKit/commit/070356a60a77ee878b21ce8c9d2dda7a3d1c4257
Author: Keith Miller <[email protected]>
Date: 2026-09-01 (Tue, 01 Sep 2026)
Changed paths:
M Source/WebGPU/WGSL/CMakeLists.txt
M Source/WebKit/WPEPlatform/CMakeLists.txt
M Source/WebKit/WPEPlatform/wpe/drm/CMakeLists.txt
M Source/WebKit/WPEPlatform/wpe/headless/CMakeLists.txt
M Source/cmake/WebKitCompilerFlags.cmake
M Source/cmake/WebKitMacros.cmake
Log Message:
-----------
[CMake] Enable -Werror globally in DEVELOPER_MODE
https://bugs.webkit.org/show_bug.cgi?id=323109
rdar://186366829
Reviewed by Elliott Williams.
Right now `-Werror` is set per-target. This is error prone (pun intended).
After this change when in DEVELOPER_MODE with fatal warnings, which is
the default, we prepend `-Werror`. This matches the xcodebuild's use
of `-Werror` which is set in every Base.xconfig, although, it should
probably move to CommonBase.xconfig.
I didn't move Swift's logic for setting the flags `-Werror` since
WebKitCompilerFlags.cmake is initialized before SWIFT_ENABLED is set
for a given port. If/when we require Swift for all ports we can
reconsider moving those definitions.
Canonical link: https://commits.webkit.org/320261@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
