Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 79d2c1780410b725f1dcaace7c5033198825a784
https://github.com/WebKit/WebKit/commit/79d2c1780410b725f1dcaace7c5033198825a784
Author: Qianlang Chen <[email protected]>
Date: 2026-09-01 (Tue, 01 Sep 2026)
Changed paths:
R
LayoutTests/http/tests/site-isolation/inspector/storage/storage-frontend-gate-expected.txt
R
LayoutTests/http/tests/site-isolation/inspector/storage/storage-frontend-gate.html
M LayoutTests/platform/mac-site-isolation/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations
Log Message:
-----------
[Site Isolation] Web Inspector: Remove the invalid storage-frontend-gate.html
test
rdar://185838038
https://bugs.webkit.org/show_bug.cgi?id=322541
Reviewed by BJ Burg.
Remove the storage-frontend-gate.html layout test that's currently
failing, as it tried to test a behavior that was not valid:
It asserted that WI.storageManager.shouldUseStorageDomain is false at
startup and flips to true once a cross-origin iframe becomes its own
frame target. This is incorrect. First, Site Isolation is forced on
for the whole test since it's in the site-isolation/inspector/ test
suite, so there is no "before Site Isolation is active" state to
observe. But more importantly, under SI, the main frame also surfaces
a frame target, so the gate is already true when the frontend
connects. The gate is not meant to flip partway through a session due
to a cross-origin iframe loading.
What the test meant to verify is already covered by the adjacent
storage-get-cookies-cross-origin-iframe.html, which observes the correct
behavior of the feature rather than the frontend flag: it checks that
Storage.getCookies sees a cookie set by script inside a cross-origin
iframe and that Page.getCookies does not.
*
LayoutTests/http/tests/site-isolation/inspector/storage/storage-frontend-gate-expected.txt:
Removed.
*
LayoutTests/http/tests/site-isolation/inspector/storage/storage-frontend-gate.html:
Removed.
* LayoutTests/platform/mac-site-isolation/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/320269@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
