Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a01fa7d4f4fec6d8b5842ccfcb18d1a72a031e70
https://github.com/WebKit/WebKit/commit/a01fa7d4f4fec6d8b5842ccfcb18d1a72a031e70
Author: Tyler Wilcock <[email protected]>
Date: 2026-09-01 (Tue, 01 Sep 2026)
Changed paths:
A
LayoutTests/accessibility/mac/autocorrection-occurred-notification-expected.txt
A LayoutTests/accessibility/mac/autocorrection-occurred-notification.html
A LayoutTests/accessibility/mac/label-changed-notification-expected.txt
A LayoutTests/accessibility/mac/label-changed-notification.html
A
LayoutTests/accessibility/mac/press-did-succeed-notification-collapse-expected.txt
A LayoutTests/accessibility/mac/press-did-succeed-notification-collapse.html
A LayoutTests/accessibility/mac/press-did-succeed-notification-expected.txt
A LayoutTests/accessibility/mac/press-did-succeed-notification.html
M Source/WebCore/accessibility/AXObjectCache.cpp
Log Message:
-----------
AX: Add layout tests for the AXPressDidSucceed, AXTitleChanged, and
AXAutocorrectionOccurred notifications
https://bugs.webkit.org/show_bug.cgi?id=323128
rdar://186390534
Reviewed by Dominic Mazzoni.
Three AXNotification kinds are observable from the platform but had no test
waiting for them. Each new test asserts two things:
1. That the notification fires,
2. The state an assistive technology would query in response is already
correct at the moment of delivery.
* LayoutTests/accessibility/mac/press-did-succeed-notification.html: Added.
* LayoutTests/accessibility/mac/press-did-succeed-notification-expected.txt:
Added.
- First test to wait for AXPressDidSucceed. Pressing a collapsed
base-appearance select reports itself expanded at delivery.
* LayoutTests/accessibility/mac/press-did-succeed-notification-collapse.html:
Added.
*
LayoutTests/accessibility/mac/press-did-succeed-notification-collapse-expected.txt:
Added.
- The collapsing direction of the same invariant. Split from the test above so
that only the direction that fails with the isolated tree is gardened (yes,
this exposed a bug).
* LayoutTests/accessibility/mac/label-changed-notification.html: Added.
* LayoutTests/accessibility/mac/label-changed-notification-expected.txt: Added.
- First test to wait for AXTitleChanged, which AXNotification::LabelChanged is
the sole source of.
* LayoutTests/accessibility/mac/autocorrection-occurred-notification.html:
Added.
*
LayoutTests/accessibility/mac/autocorrection-occurred-notification-expected.txt:
Added.
- First test to wait for AXAutocorrectionOccurred.
* LayoutTests/accessibility-isolated-tree/TestExpectations:
- Garden press-did-succeed-notification-collapse.html. AXPressDidSucceed is
posted synchronously by AccessibilityRenderObject::press(), but the isolated
tree only learns the collapsed state from the IsExpanded update that
ExpandedChanged queues, which lands after the notification.
Canonical link: https://commits.webkit.org/320306@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
