Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: afbe314b93fc84ded1e57c21a32d955cd6197931
https://github.com/WebKit/WebKit/commit/afbe314b93fc84ded1e57c21a32d955cd6197931
Author: Mark Lam <[email protected]>
Date: 2026-09-02 (Wed, 02 Sep 2026)
Changed paths:
M Source/JavaScriptCore/corpse/tests/CorpseAddressTest.cpp
M Source/JavaScriptCore/corpse/tests/CorpseByteParserTest.cpp
M Source/JavaScriptCore/corpse/tests/CorpseExportsTrieTest.cpp
M Source/JavaScriptCore/corpse/tests/CorpseProcessTest.cpp
M Source/JavaScriptCore/corpse/tests/CorpseRegionTest.cpp
M Source/JavaScriptCore/corpse/tests/CorpseSnapshotTest.cpp
M Source/JavaScriptCore/corpse/tests/CorpseSymbolTest.cpp
M Source/JavaScriptCore/corpse/tests/CorpseThreadTest.cpp
M Source/JavaScriptCore/corpse/tests/LibJSCToolsTestUtilities.cpp
M Source/JavaScriptCore/corpse/tests/LibJSCToolsTestUtilities.h
M Source/JavaScriptCore/corpse/tests/testLibJSCTools.cpp
Log Message:
-----------
Enhance testLibJSCTools to track test suite run time, and fix an intermittent
hang.
https://bugs.webkit.org/show_bug.cgi?id=323167
rdar://186413086
Reviewed by Marcus Plutowski and Dan Hecht.
Now introducing and using a SuiteTracer RAII class to track testLibJSCTools'
test suite
run times. We will use this to make sure test suites don't take too long to
run. To dumpi
run times, run testLibJSCTools with the --verbose option.
The intermittent hang is due to spurious wakes from waits in testProcess() and
its utility
function, reapedChildPid(). These functions were not previously accounting for
the spurious
wakes. This is now fixed.
No new tests because this change is for enhancing and fixing an existing test.
* Source/JavaScriptCore/corpse/tests/CorpseAddressTest.cpp:
(JSCToolsTest::testAddress):
* Source/JavaScriptCore/corpse/tests/CorpseByteParserTest.cpp:
(JSCToolsTest::testByteParser):
* Source/JavaScriptCore/corpse/tests/CorpseExportsTrieTest.cpp:
(JSCToolsTest::testExportsTrie):
(JSCToolsTest::fuzzExportsTrie):
* Source/JavaScriptCore/corpse/tests/CorpseProcessTest.cpp:
(JSCToolsTest::reapedChildPid):
(JSCToolsTest::testProcess):
* Source/JavaScriptCore/corpse/tests/CorpseRegionTest.cpp:
(JSCToolsTest::testRegion):
* Source/JavaScriptCore/corpse/tests/CorpseSnapshotTest.cpp:
(JSCToolsTest::testSnapshot):
* Source/JavaScriptCore/corpse/tests/CorpseSymbolTest.cpp:
(JSCToolsTest::testSymbol):
* Source/JavaScriptCore/corpse/tests/CorpseThreadTest.cpp:
(JSCToolsTest::testThreads):
* Source/JavaScriptCore/corpse/tests/LibJSCToolsTestUtilities.cpp:
(JSCToolsTest::SuiteTracer::SuiteTracer):
(JSCToolsTest::SuiteTracer::~SuiteTracer):
(JSCToolsTest::totalSuiteTime):
(JSCToolsTest::beginSuite): Deleted.
* Source/JavaScriptCore/corpse/tests/LibJSCToolsTestUtilities.h:
(JSCToolsTest::SuiteTracer::shouldRun const):
* Source/JavaScriptCore/corpse/tests/testLibJSCTools.cpp:
(main):
Canonical link: https://commits.webkit.org/320337@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
