Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 951d88a0fe8bffd6a1d0e80c42a019a28c416720
https://github.com/WebKit/WebKit/commit/951d88a0fe8bffd6a1d0e80c42a019a28c416720
Author: Mark Lam <[email protected]>
Date: 2026-09-02 (Wed, 02 Sep 2026)
Changed paths:
M Source/JavaScriptCore/corpse/tests/CorpseSnapshotTest.cpp
M Source/JavaScriptCore/corpse/tests/CorpseSymbolTest.cpp
Log Message:
-----------
Fix testLibJSCTools's CorpseSnapshotTest and CorpseSymbolTest to run better
for ASAN builds.
https://bugs.webkit.org/show_bug.cgi?id=323232
rdar://186484113
Reviewed by Dan Hecht.
CorpseSymbolTest was previously looking up the symbol for `malloc`. ASAN
builds overrides `malloc`
with its own implementation, which causes the test to fail. We now change
CorpseSymbolTest to look
up `tolower` from the standard C library instead.
A test in CorpseSnapshotTest was doing 100 interactions of creating Snapshots
and requesting their
threads list. This was done to see if the operations leak any mach ports. As
a result, this test
was taking on the order of 1.1 seconds to run for a Release / Debug build, and
~9 seconds for an
ASAN build.
CorpseSnapshotTest is now fixed to run that test exactly once and confirm that
there's no increase
in mach ports allocated. CorpseSnapshotTest now takes 60-90 ms to run.
No new tests because this is a test fix.
* Source/JavaScriptCore/corpse/tests/CorpseSnapshotTest.cpp:
(JSCToolsTest::testSnapshot):
* Source/JavaScriptCore/corpse/tests/CorpseSymbolTest.cpp:
(JSCToolsTest::testSymbol):
Canonical link: https://commits.webkit.org/320353@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
