Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: feef6b15dd31a63cee29678a4d836472ba075a4b
https://github.com/WebKit/WebKit/commit/feef6b15dd31a63cee29678a4d836472ba075a4b
Author: Yulun Wu <[email protected]>
Date: 2026-09-02 (Wed, 02 Sep 2026)
Changed paths:
A LayoutTests/ipc/getpixelbuffer-layerbacking-heap-disclosure-expected.txt
A LayoutTests/ipc/getpixelbuffer-layerbacking-heap-disclosure.html
M Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.cpp
M
Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBitmapBackend.cpp
Log Message:
-----------
putPixelBuffer() and getPixelBuffer() are not applicable for LayerBacking()
https://bugs.webkit.org/show_bug.cgi?id=318455
rdar://177958824
Reviewed by Said Abou-Hallawa.
Per 264004@main, putPixelBuffer() and getPixelBuffer() are not applicable
for LayerBacking. This PR enforces that comment by adding a MESSAGE_CHECK().
This PR also updates the no-op override to zero-fill its
destination instead of leaving it uninitialized to fail gracefully
on release builds while still hitting the assert in debug.
* LayoutTests/ipc/getpixelbuffer-layerbacking-heap-disclosure-expected.txt:
Added.
* LayoutTests/ipc/getpixelbuffer-layerbacking-heap-disclosure.html: Added.
* Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.cpp:
(WebKit::RemoteImageBuffer::getPixelBuffer):
(WebKit::RemoteImageBuffer::putPixelBuffer):
*
Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBitmapBackend.cpp:
(WebKit::ImageBufferShareableMappedIOSurfaceBitmapBackend::getPixelBuffer):
Originally-landed-as: [email protected] (47dab0040d33).
rdar://185367113
Canonical link: https://commits.webkit.org/320358@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications