Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 25aa5a18fc2f6831a3e18e1a69ab113e602ffaf9
https://github.com/WebKit/WebKit/commit/25aa5a18fc2f6831a3e18e1a69ab113e602ffaf9
Author: Claudio Saavedra <[email protected]>
Date: 2026-09-03 (Thu, 03 Sep 2026)
Changed paths:
M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/failures.js
M
Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/investigate.js
Log Message:
-----------
[resultsdbpy] Fix endless loading spinner in the investigate drawer when a
failures query returns no results
https://bugs.webkit.org/show_bug.cgi?id=319693
Reviewed by Jonathan Bedard.
When the failures endpoint returned something other than a JSON array (for
example a 404 error object when no run matched the query), Failures.fromEndpoint
returned from its response handler without ever resolving or rejecting its
promise. The investigate drawer left the failure list in its null "loading"
state, so it showed a spinner indefinitely.
Resolve the promise with the (possibly empty) result on a non-array response,
and in the drawer handle an empty result and a rejected fetch by rendering an
empty failure list instead of leaving the spinner up.
Canonical link: https://commits.webkit.org/320408@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
