Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 99bcbf16626d2c7ca9707ef1d499fa02327f441b
https://github.com/WebKit/WebKit/commit/99bcbf16626d2c7ca9707ef1d499fa02327f441b
Author: Brent Fulgham <[email protected]>
Date: 2026-09-03 (Thu, 03 Sep 2026)
Changed paths:
M Source/WebKit/UIProcess/Automation/Automation.json
M Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
M Source/WebKit/UIProcess/Automation/WebAutomationSession.h
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKHTTPCookieStore.mm
Log Message:
-----------
[WebDriver] deleteAllCookies implementation ignores completion handler and
always returns success
https://bugs.webkit.org/show_bug.cgi?id=323158
rdar://186410147
Reviewed by BJ Burg.
WebDriver's implementation of deleteAllCookies discards its completion handler
and returns
success before the network process has actually deleted and saved the cookies.
Since the
delete process is asynchronous, we create a race condition that can lead to
downstream test
failures, implying bugs in WebKit that are not present in real Safari.
Fixing this will avoid bugs in one cookie-based WPT from poisoning other steps.
This patch corrects that problem, and make the command match the behavior of
the other
cookie features.
Tested with a new API test.
* Source/WebKit/UIProcess/Automation/Automation.json:
* Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::deleteAllCookies):
* Source/WebKit/UIProcess/Automation/WebAutomationSession.h:
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKHTTPCookieStore.mm:
(TEST(WKHTTPCookieStore, AutomationDeleteAllCookiesWaitsForDeletion)):
Canonical link: https://commits.webkit.org/320440@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
