Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f8e5626fddd9625271f3eb084950be6ba42b74b1
https://github.com/WebKit/WebKit/commit/f8e5626fddd9625271f3eb084950be6ba42b74b1
Author: Ahmad Saleem <[email protected]>
Date: 2026-09-03 (Thu, 03 Sep 2026)
Changed paths:
M Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp
Log Message:
-----------
Simplify icon "purpose" parsing in ApplicationManifestParser
https://bugs.webkit.org/show_bug.cgi?id=323299
rdar://186547640
Reviewed by Chris Dumez.
The three code paths handling an icon's "purpose" member each duplicated
the `currentIcon.purposes = purposes;` assignment, nested two levels deep.
Hoist that assignment to a single statement after the branches and flatten
the else-if chain. No behavior change: a missing or non-string "purpose"
still defaults to Any, valid keywords are still collected, and an icon whose
"purpose" contains no valid keywords is still dropped.
* Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp:
(WebCore::ApplicationManifestParser::parseIcons):
Canonical link: https://commits.webkit.org/320482@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
