Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 10ace68e7cd8d81ef2da87b682e4df3ca7e67637
https://github.com/WebKit/WebKit/commit/10ace68e7cd8d81ef2da87b682e4df3ca7e67637
Author: Alan Baradlay <[email protected]>
Date: 2026-09-04 (Fri, 04 Sep 2026)
Changed paths:
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXTextMarker.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp
M Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp
M Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.h
M Source/WebCore/layout/integration/LayoutIntegrationBoxTreeUpdater.cpp
M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
M Source/WebCore/layout/integration/inline/InlineIteratorLineBox.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h
M Source/WebCore/page/LocalFrameViewLayoutContext.cpp
M Source/WebCore/page/LocalFrameViewLayoutContext.h
M Source/WebCore/rendering/LegacyInlineIterator.h
M Source/WebCore/rendering/OutlinePainter.cpp
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderElementInlines.h
M Source/WebCore/rendering/RenderInline.cpp
M Source/WebCore/rendering/RenderListItem.cpp
M Source/WebCore/rendering/RenderListItem.h
R Source/WebCore/rendering/RenderListMarker.cpp
R Source/WebCore/rendering/RenderListMarker.h
A Source/WebCore/rendering/RenderListOutsideMarker.cpp
A Source/WebCore/rendering/RenderListOutsideMarker.h
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderObject.h
M Source/WebCore/rendering/RenderText.cpp
M Source/WebCore/rendering/RenderTreeAsText.cpp
M Source/WebCore/rendering/TextAutoSizing.cpp
M Source/WebCore/rendering/line/BreakingContext.h
M Source/WebCore/rendering/updating/RenderTreeBuilder.h
M Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderList.h
M Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp
M Source/WebCore/style/Styleable.cpp
Log Message:
-----------
[list-marker] Rename RenderListMarker to RenderListOutsideMarker
https://bugs.webkit.org/show_bug.cgi?id=323226
rdar://problem/186472147
Reviewed by Antti Koivisto.
An inside marker is built as an anonymous inline box now, so this renderer is
only ever created for
list-style-position: outside: the marker the list item excludes from its
content and positions itself. Name it for
what it is.
renderName() keeps returning "RenderListMarker" so that no expected results
move; the name in the render tree dumps
is what the marker is called in CSS terms, not the class name.
No change in behavior.
* Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::onTextRunsChanged):
* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::AXTextMarkerRange::toString const):
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canHaveChildren const):
(WebCore::AccessibilityNodeObject::stitchGroups const):
(WebCore::AccessibilityNodeObject::stringValue const):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::parentObject const):
(WebCore::AccessibilityRenderObject::textUnderElement const):
(WebCore::AccessibilityRenderObject::stringValue const):
(WebCore::AccessibilityRenderObject::boundingBoxRect const):
(WebCore::AccessibilityRenderObject::computeIsIgnored const):
(WebCore::AccessibilityRenderObject::listMarkerText const):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::addChildren):
* Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::textAttributes const):
* Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp:
(WebCore::LayoutIntegration::BoxGeometryUpdater::setListMarkerOffsetForMarkerOutside):
(WebCore::LayoutIntegration::baselineForBox):
(WebCore::LayoutIntegration::setIntegrationBaseline):
(WebCore::LayoutIntegration::BoxGeometryUpdater::updateBoxGeometryAfterIntegrationLayout):
(WebCore::LayoutIntegration::BoxGeometryUpdater::updateBoxGeometry):
* Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.h:
* Source/WebCore/layout/integration/LayoutIntegrationBoxTreeUpdater.cpp:
(WebCore::LayoutIntegration::elementAttributes):
(WebCore::LayoutIntegration::calculateListMarkerAttribute):
(WebCore::LayoutIntegration::BoxTreeUpdater::createLayoutBox):
(WebCore::LayoutIntegration::BoxTreeUpdater::updateStyle):
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForIntrinsicWidthComputation):
* Source/WebCore/layout/integration/inline/InlineIteratorLineBox.cpp:
(WebCore::InlineIterator::closestBoxForHorizontalPosition):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h:
* Source/WebCore/page/LocalFrameViewLayoutContext.cpp:
(WebCore::ListItemExcludedMarkerScope::ListItemExcludedMarkerScope):
* Source/WebCore/page/LocalFrameViewLayoutContext.h:
* Source/WebCore/rendering/LegacyInlineIterator.h:
(WebCore::LegacyInlineIterator::direction const):
* Source/WebCore/rendering/OutlinePainter.cpp:
(WebCore::OutlinePainter::collectFocusRingRectsForInline):
* Source/WebCore/rendering/RenderBlock.cpp:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::computeInlineIntrinsicLogicalWidths const):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::lineHeight const):
* Source/WebCore/rendering/RenderElementInlines.h:
(WebCore::RenderElement::isAnonymousBlock const):
* Source/WebCore/rendering/RenderInline.cpp:
* Source/WebCore/rendering/RenderListItem.cpp:
(WebCore::RenderListItem::excludedMarker const):
(WebCore::RenderListItem::markerBox const):
(WebCore::RenderListItem::placeExcludedMarker):
(WebCore::RenderListItem::excludedMarkersForContainer):
* Source/WebCore/rendering/RenderListItem.h:
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::isExcludedMarker const):
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::isRenderListOutsideMarker const):
(WebCore::RenderObject::isRenderListMarker const): Deleted.
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::setRenderedText):
* Source/WebCore/rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::write):
(WebCore::markerTextForListItem):
* Source/WebCore/rendering/TextAutoSizing.cpp:
(WebCore::TextAutoSizingValue::adjustTextNodeSizes):
* Source/WebCore/rendering/line/BreakingContext.h:
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):
* Source/WebCore/rendering/updating/RenderTreeBuilder.h:
* Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp:
(WebCore::isExcludedMarker):
* Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp:
(WebCore::firstNonMarkerChild):
(WebCore::parentCandidateForMarker):
(WebCore::RenderTreeBuilder::List::updateItemMarker):
(WebCore::RenderTreeBuilder::List::buildMarkerContentRenderers):
* Source/WebCore/rendering/updating/RenderTreeBuilderList.h:
* Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp:
(WebCore::RenderTreeBuilder::MultiColumn::createFragmentedFlow):
* Source/WebCore/style/Styleable.cpp:
* Source/WebCore/rendering/RenderListOutsideMarker.cpp: Renamed from
Source/WebCore/rendering/RenderListMarker.cpp.
(WebCore::RenderListOutsideMarker::RenderListOutsideMarker):
(WebCore::RenderListOutsideMarker::willBeDestroyed):
(WebCore::adjustedStyleDifference):
(WebCore::RenderListOutsideMarker::styleWillChange):
(WebCore::RenderListOutsideMarker::styleDidChange):
(WebCore::RenderListOutsideMarker::isImage const):
(WebCore::RenderListOutsideMarker::hasContentProperty const):
(WebCore::RenderListOutsideMarker::textNeedsBidiResolution const):
(WebCore::RenderListOutsideMarker::needsContentContainer const):
(WebCore::RenderListOutsideMarker::contentContainer const):
(WebCore::RenderListOutsideMarker::localSelectionRect):
(WebCore::RenderListOutsideMarker::paint):
(WebCore::RenderListOutsideMarker::parentBox):
(WebCore::RenderListOutsideMarker::layout):
(WebCore::RenderListOutsideMarker::layoutContentContainer):
(WebCore::RenderListOutsideMarker::imageChanged):
(WebCore::RenderListOutsideMarker::updateInlineMarginsAndContent):
(WebCore::RenderListOutsideMarker::updateContent):
(WebCore::RenderListOutsideMarker::updateContentContainerText):
(WebCore::RenderListOutsideMarker::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderListOutsideMarker::updateInlineMargins):
(WebCore::RenderListOutsideMarker::isDisclosureMarker const):
(WebCore::RenderListOutsideMarker::listItem const):
(WebCore::RenderListOutsideMarker::setExcludedPosition):
(WebCore::RenderListOutsideMarker::invalidateExcludedMarkerContainer):
(WebCore::RenderListOutsideMarker::nodeForHitTest const):
(WebCore::RenderListOutsideMarker::relativeMarkerRect):
(WebCore::RenderListOutsideMarker::selectionRectForRepaint):
(WebCore::RenderListOutsideMarker::counterStyle const):
(WebCore::RenderListOutsideMarker::synthesizesGlyph const):
(WebCore::RenderListOutsideMarker::layoutBoundForTextContent const):
* Source/WebCore/rendering/RenderListOutsideMarker.h: Renamed from
Source/WebCore/rendering/RenderListMarker.h.
Canonical link: https://commits.webkit.org/320509@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
