Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 56d21bcfd6717fd472ee2ba7d73776e6a9eb6e0d
https://github.com/WebKit/WebKit/commit/56d21bcfd6717fd472ee2ba7d73776e6a9eb6e0d
Author: Adrian Taylor <[email protected]>
Date: 2026-09-04 (Fri, 04 Sep 2026)
Changed paths:
M Source/WebGPU/WebGPU/CMakeLists.txt
M Source/cmake/OptionsCocoa.cmake
M Source/cmake/WebKitFeatures.cmake
M Source/cmake/WebKitMacros.cmake
Log Message:
-----------
[cmake] Set ENABLE_WEBGPU_SWIFT correctly
https://bugs.webkit.org/show_bug.cgi?id=323430
rdar://186653895
Reviewed by Mike Wyrzykowski.
In the cmake build, previously ENABLE_WEBGPU_SWIFT was only being defined for
the Swift clang importer, not for regular C++ clang compiles. This currently
caused no problems, but if we ever added a type whose layout depended on that
ifdef, then Swift and C++ would see different offsets/layouts in that type.
Promote ENABLE_WEBGPU_SWIFT to being a normal option.
Note that in theory this could harm build performance by causing us to build
multiple copies of PCM files (per the comment just above the change in
WebKitMacros.cmake). In practice, we already build several PCMs for many modules
so the rationale in that comment no longer really holds. A follow-up commit
will attempt to reduce that down again to improve build speed.
Canonical link: https://commits.webkit.org/320511@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
