Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1be505b36f434138574ce6db35417577c7c44146
https://github.com/WebKit/WebKit/commit/1be505b36f434138574ce6db35417577c7c44146
Author: Issac Roy <[email protected]>
Date: 2026-09-04 (Fri, 04 Sep 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/balance/flex-line-count-computed-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/balance/flex-line-count-valid-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/shadow-dom-expected.txt
M
LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M
LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/rendering/widgets/shadow-dom-expected.txt
M
LayoutTests/platform/ios-26/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M
LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/shadow-dom-expected.txt
M
LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M Source/WebCore/Headers.cmake
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/style/computed/StyleComputedStyleBase.h
M Source/WebCore/style/computed/data/StyleFlexibleBoxData.cpp
M Source/WebCore/style/computed/data/StyleFlexibleBoxData.h
A Source/WebCore/style/values/flexbox/StyleFlexLineCount.h
Log Message:
-----------
[Flex Wrap Balance] Add parsing support for flex-line-count
https://bugs.webkit.org/show_bug.cgi?id=323392
rdar://186619043
Reviewed by Tim Nguyen and Sam Weinig.
Adds flex-line-count as <integer [1,∞]>, initial value 1, per css-flexbox-2
§6.1. Storage, parsing and computed-style serialization only; the value does not
affect layout yet, which is bug 323240.
The property is gated on the existing CSSFlexWrapBalanceEnabled setting rather
than a new one, because it only has an effect on a balanced container — see
balance-min-line-count-007 and -008, which assert it changes nothing under
flex-wrap: wrap and nowrap. That setting is already status: testable, so the WPT
syntax tests run with it enabled and stay byte-identical to upstream.
Style::FlexLineCount is Integer<CSS::Positive>, and CSS::Positive is Range { 1,
Range::infinity }, which is exactly the grammar's range. It is a value member of
FlexibleBoxData next to flexBasis, not a bitfield, so calc() results wider than
a few bits round-trip.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/balance/flex-line-count-computed-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/balance/flex-line-count-valid-expected.txt:
* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/style/computed/StyleComputedStyleBase.h:
* Source/WebCore/style/computed/data/StyleFlexibleBoxData.cpp:
* Source/WebCore/style/computed/data/StyleFlexibleBoxData.h:
* Source/WebCore/style/values/flexbox/StyleFlexLineCount.h: Added.
Canonical link: https://commits.webkit.org/320530@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
