Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 65dd1d3fccd053730b9e2881484c1694a6a2d794
      
https://github.com/WebKit/WebKit/commit/65dd1d3fccd053730b9e2881484c1694a6a2d794
  Author: Alan Baradlay <[email protected]>
  Date:   2026-09-04 (Fri, 04 Sep 2026)

  Changed paths:
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-lists/outside-marker-with-align-content-expected.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-lists/outside-marker-with-align-content-ref.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-lists/outside-marker-with-align-content.html
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
    M Source/WebCore/rendering/RenderListItem.cpp
    M Source/WebCore/rendering/RenderListItem.h

  Log Message:
  -----------
  [list-marker] align-content leaves the list marker behind
https://bugs.webkit.org/show_bug.cgi?id=323445
rdar://problem/186676835

Reviewed by Antti Koivisto.

An outside marker is positioned against a line 
(RenderListItem::placeExcludedMarker) and takes no part in the inline
content of that line. align-content moves the lines after they are built, and 
LineLayout::shiftLinesByInBlockDirection
moves the lines and the renderers of the boxes on them, so the marker stayed 
where the unshifted line was.

Move the position the marker was given by the same amount.

Test: 
imported/w3c/web-platform-tests/css/css-lists/outside-marker-with-align-content.html

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-lists/outside-marker-with-align-content-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-lists/outside-marker-with-align-content-ref.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-lists/outside-marker-with-align-content.html:
 Added.
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::shiftLinesByInBlockDirection):
* Source/WebCore/rendering/RenderListItem.cpp:
(WebCore::RenderListItem::excludedMarkerAnchoredTo):
* Source/WebCore/rendering/RenderListItem.h:

Canonical link: https://commits.webkit.org/320532@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to