Branch: refs/heads/webkitglib/2.54
Home: https://github.com/WebKit/WebKit
Commit: 36ddec04375f64888872779e90a57d418d146cf3
https://github.com/WebKit/WebKit/commit/36ddec04375f64888872779e90a57d418d146cf3
Author: Fady Farag <[email protected]>
Date: 2026-09-04 (Fri, 04 Sep 2026)
Changed paths:
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/Element.cpp
Log Message:
-----------
Cherry-pick 320499@main (c9d3d549bac5).
https://bugs.webkit.org/show_bug.cgi?id=323388
Remove incorrect `NODELETE` annotation from
`Document::invalidateAccessKeyCacheSlowCase()`
https://bugs.webkit.org/show_bug.cgi?id=323388
rdar://186618132
Reviewed by Chris Dumez.
Drop `NODELETE` from function that destroys objects since it is a lie.
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::attributeChanged):
Canonical link: https://commits.webkit.org/320499@main
Canonical link: https://commits.webkit.org/317695.195@webkitglib/2.54
Commit: 1f24b788db7fff4cc95e03d5a84ad561505fae5a
https://github.com/WebKit/WebKit/commit/1f24b788db7fff4cc95e03d5a84ad561505fae5a
Author: Zak Ridouh <[email protected]>
Date: 2026-09-04 (Fri, 04 Sep 2026)
Changed paths:
M Source/WebCore/testing/Internals.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
Log Message:
-----------
Cherry-pick 320513@main (2a20415140e2).
https://bugs.webkit.org/show_bug.cgi?id=322203
Null-check history items in history dumping testing code
https://bugs.webkit.org/show_bug.cgi?id=322203
rdar://185442169
Reviewed by David Kilzer.
WebPage::dumpHistoryForTesting() and Internals::getReferencedFilePaths()
dereferenced a nullable history item without checking it.
In dumpHistoryForTesting(), itemAtIndex() takes an offset relative to the
current item, so the range of valid offsets is [-backCount(),
forwardCount()]
inclusive. backCount() and forwardCount() are served from a cached value in
WebBackForwardListProxy, while itemAtIndex() is a separate synchronous
message
to the UI process, so the bounds and the items are sampled at different
times
and itemAtIndex() can return null at an offset the bounds include. Skip
those
entries. A page with no current item at all has nothing to dump, so return
early: WebKitTestRunner dumps every page it knows about, and a page created
by
window.open() has no current item until its initial load commits.
In getReferencedFilePaths(), only the frame was checked.
HistoryController::currentItem() is null until a load commits, and
saveDocumentAndScrollState() does not create an item.
Both are only reachable from test infrastructure, so this replaces a
WebContent
process crash with a skipped entry.
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::getReferencedFilePaths const):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::dumpHistoryForTesting):
Canonical link: https://commits.webkit.org/320513@main
Canonical link: https://commits.webkit.org/317695.196@webkitglib/2.54
Compare: https://github.com/WebKit/WebKit/compare/b37fadaddeee...1f24b788db7f
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
