Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 97577612f28b46ada2aad43e56138221cd26e135
https://github.com/WebKit/WebKit/commit/97577612f28b46ada2aad43e56138221cd26e135
Author: Tyler Wilcock <[email protected]>
Date: 2026-09-05 (Sat, 05 Sep 2026)
Changed paths:
A
LayoutTests/accessibility/isolated-tree/video-element-url-attribute-expected.txt
A LayoutTests/accessibility/isolated-tree/video-element-url-attribute.html
M LayoutTests/accessibility/video-element-url-attribute-expected.txt
M LayoutTests/accessibility/video-element-url-attribute.html
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/html/HTMLMediaElement.cpp
Log Message:
-----------
AX: In isolated tree mode, a video's URL is never updated when resource
selection picks a new source
https://bugs.webkit.org/show_bug.cgi?id=323354
rdar://186597296
Reviewed by Chris Fleizach and Dominic Mazzoni.
AccessibilityNodeObject::url() reports HTMLMediaElement::currentSrc() for a
video,
and the isolated tree caches that as AXProperty::URL. The only thing that
refreshes it is the src attribute change handler posting URLChanged. currentSrc,
though, is set by the resource selection algorithm, which runs asynchronously,
so
that notification is frequently handled while currentSrc still holds the
previous
value -- and since nothing fires when it does resolve, the cached URL then stays
stale for good.
Instead, this commit notifes the cache from HTMLMediaElement::setCurrentSrc,
which
every resource selection path funnels through, after the URL has actually
changed.
Makes video-element-url-attribute.html pass in ITM.
*
LayoutTests/accessibility/isolated-tree/video-element-url-attribute-expected.txt:
Copied from LayoutTests/accessibility/video-element-url-attribute-expected.txt.
* LayoutTests/accessibility/isolated-tree/video-element-url-attribute.html:
Copied from LayoutTests/accessibility/video-element-url-attribute.html.
* LayoutTests/accessibility/video-element-url-attribute-expected.txt:
* LayoutTests/accessibility/video-element-url-attribute.html:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::onMediaElementCurrentSrcChanged):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setCurrentSrc):
Canonical link: https://commits.webkit.org/320562@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
