Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8376e905e7fad8d131a2e84243b97a81fc721f5c
https://github.com/WebKit/WebKit/commit/8376e905e7fad8d131a2e84243b97a81fc721f5c
Author: Tyler Wilcock <[email protected]>
Date: 2026-09-05 (Sat, 05 Sep 2026)
Changed paths:
M LayoutTests/accessibility-isolated-tree/TestExpectations
M LayoutTests/accessibility/mac/set-value-editable-types.html
Log Message:
-----------
AX: set-value-editable-types.html handles a value change notification twice
in isolated tree mode
https://bugs.webkit.org/show_bug.cgi?id=323512
rdar://186749414
Reviewed by Chris Fleizach.
Setting the value of a contenteditable posts several AXValueChanged
notifications rather than one.
AccessibilityRenderObject::setValue clears the text and inserts the new text
through the editor, and
the deferred cache update then reports the same change again. That is tracked
separately in https://bugs.webkit.org/show_bug.cgi?id=323512.
The test's listener means to handle the first of them, but it hides the content
and unregisters
itself only after reading an accessibility attribute, and in isolated tree mode
that read waits on
the accessibility thread, which lets the main thread deliver the next
notification re-entrantly. The
listener therefore ran a second time, with the content already hidden, and
printed an extra pair of
lines with an empty value.
Unregister first, so the listener can only run once no matter when the
remaining notifications land.
* LayoutTests/accessibility-isolated-tree/TestExpectations: Unskip the test.
* LayoutTests/accessibility/mac/set-value-editable-types.html:
Canonical link: https://commits.webkit.org/320574@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
