Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5bf2f65bb5a72c248b63c93e9ced077d9853ec68
https://github.com/WebKit/WebKit/commit/5bf2f65bb5a72c248b63c93e9ced077d9853ec68
Author: Tyler Wilcock <[email protected]>
Date: 2026-09-06 (Sun, 06 Sep 2026)
Changed paths:
A
LayoutTests/accessibility/isolated-tree/mac/attributed-string-with-listitem-multiple-lines-expected.txt
A
LayoutTests/accessibility/isolated-tree/mac/attributed-string-with-listitem-multiple-lines.html
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/accessibility/AXTextMarker.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/AccessibilityRenderObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
Log Message:
-----------
AX: In isolated tree mode, a list item whose first line is in a nested block
loses its list marker
https://bugs.webkit.org/show_bug.cgi?id=323518
rdar://186761205
Reviewed by Chris Fleizach.
listMarkerTextOnSameLine decides whether a text marker sits on the line that
shows the list marker by
comparing line IDs, and it named the marker's line with listMarkerLineID(),
which is the block the
marker renderer is parented in rather than the line the marker is drawn on.
Those agree only when the
list item's text is a direct child of the item's own block. An outside marker
is a child of the
RenderListItem, but the item's first line can live in a nested block:
<ol><li><p>First line</p>second line</li></ol>
There the text's containing block is the <p> and the marker's is the <li>, so
the two line IDs never
matched and the marker was dropped entirely -- "First line" rather than "1.
First line".
Ask the line the list item's own text starts on using the existing cached data.
This allows removal of
listMarkerLineID() and AXProperty::ListMarkerLineID.
Fixes accessibility/mac/attributed-string-with-listitem-multiple-lines.html in
ITM.
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::listMarkerTextOnSameLine):
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::listMarkerLineID const): Deleted.
* Source/WebCore/accessibility/AccessibilityRenderObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::isDefaultValue):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::createIsolatedObjectData):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
Canonical link: https://commits.webkit.org/320595@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
