Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7d262597e8a319def4d2fbb7c00c7d804c16f6fa
https://github.com/WebKit/WebKit/commit/7d262597e8a319def4d2fbb7c00c7d804c16f6fa
Author: Youenn Fablet <[email protected]>
Date: 2026-09-08 (Tue, 08 Sep 2026)
Changed paths:
M Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.cpp
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.cpp
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.h
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.messages.in
Log Message:
-----------
LibWebRTCNetwork::SignalReadPacket should take a SocketAddress
rdar://186844957
https://bugs.webkit.org/show_bug.cgi?id=323602
Reviewed by Chris Dumez.
Before the PR, on signal read packet, we send back a socket address to
libwebrtc from an IP address and a port given by network process.
This IP address and port are coming from a socket address given by web process
at connection time.
This all works well except if the socket address contains a host and not an IP
address.
In that case, libwebrtc is not getting the socket address it expects and is
dropping packets.
We simplify this by sending via IPC the SocketAddress instead of IP address +
port.
This also simplifies a bit the handling in both web and networking process.
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm:
(WebKit::NetworkRTCTCPSocketCocoa::NetworkRTCTCPSocketCocoa):
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:
(WebKit::NetworkRTCUDPSocketCocoaConnections::setupNWConnection):
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.cpp:
(WebKit::LibWebRTCNetwork::signalReadPacket):
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.h:
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.messages.in:
Canonical link: https://commits.webkit.org/320651@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
