Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ca3a9f205bcecd15c9d2ed0680acc25b56785109
https://github.com/WebKit/WebKit/commit/ca3a9f205bcecd15c9d2ed0680acc25b56785109
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-09-08 (Tue, 08 Sep 2026)
Changed paths:
M Tools/WebKitTestRunner/TestInvocation.cpp
M Tools/WebKitTestRunner/TestInvocation.h
Log Message:
-----------
[GTK][WPE] Pixel tests using testRunner.dontForceRepaint() are flaky
https://bugs.webkit.org/show_bug.cgi?id=323607
Reviewed by Carlos Garcia Campos.
WKPageForceRepaint() forces a repaint and then waits for the next presentation
update. On the coordinated graphics ports that wait is the only synchronization
between the rendering update in the web process and the snapshot taken by
WebKitTestRunner. Tests calling testRunner.dontForceRepaint() skipped the call
entirely, dropping the synchronization together with the repaint, and captured
whichever frame the UI process last received - fix that behavior by an
explicit wait.
Covered by existing tests, such as the recently added
css3/filters/filter-repaint-blur-nested-pixel-moving-filter.html on
GTK/WPE.
* Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::presentationUpdateDoneCallback):
(WTR::TestInvocation::waitForPresentationUpdate):
(WTR::TestInvocation::dumpResults):
* Tools/WebKitTestRunner/TestInvocation.h:
Canonical link: https://commits.webkit.org/320673@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
