Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 32b085d39b37d9d45bc931b16076168ba5c466e9
https://github.com/WebKit/WebKit/commit/32b085d39b37d9d45bc931b16076168ba5c466e9
Author: Tyler Wilcock <[email protected]>
Date: 2026-09-08 (Tue, 08 Sep 2026)
Changed paths:
A
LayoutTests/accessibility/isolated-tree/mac/press-did-fail-notification-base-select-expected.txt
A
LayoutTests/accessibility/isolated-tree/mac/press-did-fail-notification-base-select.html
A
LayoutTests/accessibility/mac/press-did-fail-notification-base-select-expected.txt
A LayoutTests/accessibility/mac/press-did-fail-notification-base-select.html
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
Log Message:
-----------
AX: A disabled base-appearance select posts no AXPressDidFail
https://bugs.webkit.org/show_bug.cgi?id=323529
rdar://186769876
Reviewed by Dominic Mazzoni.
Pressing a disabled <select> is refused, and an assistive technology learns
that from the
AXPressDidFail notification. AccessibilityMenuList::press() posts it, so the
legacy menu-list
appearance is covered --
accessibility/mac/press-not-work-for-disabled-menu-list.html presses three
disabled selects and expects a notification each time.
A base-appearance select (appearance: base-select) is not an
AccessibilityMenuList, though. It is served by
AccessibilityRenderObject::press(), which bails on isDisabledFormControl() with
a bare
"return false" and posts nothing.
Post AXPressDidFail from that branch, matching what the menu-list override
already does.
*
LayoutTests/accessibility/isolated-tree/mac/press-did-fail-notification-base-select-expected.txt:
Added.
*
LayoutTests/accessibility/isolated-tree/mac/press-did-fail-notification-base-select.html:
Added.
*
LayoutTests/accessibility/mac/press-did-fail-notification-base-select-expected.txt:
Added.
* LayoutTests/accessibility/mac/press-did-fail-notification-base-select.html:
Added.
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::press):
Canonical link: https://commits.webkit.org/320659@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
