Title: [115749] trunk
- Revision
- 115749
- Author
- [email protected]
- Date
- 2012-05-01 14:26:04 -0700 (Tue, 01 May 2012)
Log Message
Source/WebCore: Audio controls have a 1px surplus outline coming from RenderImage::paintReplaced base class,
which needs overwriting.
https://bugs.webkit.org/show_bug.cgi?id=84570
Patch by Silvia Pfeiffer <[email protected]> on 2012-05-01
Reviewed by Eric Carlson.
No new tests - covered by existing audio rendering tests.
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::paintReplaced): Overwrite inherited function.
(WebCore):
* rendering/RenderMedia.h:
(RenderMedia):
LayoutTests: Audio controls have a 1px surplus outline coming from RenderImage::paintReplaced base class,
which needs overwriting. All layout tests with an audio element need a
visual update.
https://bugs.webkit.org/show_bug.cgi?id=84570
Patch by Silvia Pfeiffer <[email protected]> on 2012-05-01
Reviewed by Eric Carlson.
* platform/chromium-linux/media/audio-controls-rendering-expected.png:
* platform/chromium-linux/media/audio-repaint-expected.png:
* platform/chromium-linux/media/controls-after-reload-expected.png:
* platform/chromium-linux/media/controls-layout-direction-expected.png:
* platform/chromium-linux/media/media-controls-clone-expected.png:
* platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png:
* platform/chromium-mac-leopard/media/audio-repaint-expected.png:
* platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
* platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png:
* platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
* platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png:
* platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png:
* platform/chromium-mac/media/audio-controls-rendering-expected.png:
* platform/chromium-mac/media/audio-repaint-expected.png:
* platform/chromium-mac/media/controls-after-reload-expected.png:
* platform/chromium-mac/media/controls-layout-direction-expected.png:
* platform/chromium-mac/media/media-controls-clone-expected.png:
* platform/chromium-win/media/audio-controls-rendering-expected.png:
* platform/chromium-win/media/audio-repaint-expected.png:
* platform/chromium-win/media/controls-after-reload-expected.png:
* platform/chromium-win/media/controls-layout-direction-expected.png:
* platform/chromium-win/media/media-controls-clone-expected.png:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (115748 => 115749)
--- trunk/LayoutTests/ChangeLog 2012-05-01 21:21:53 UTC (rev 115748)
+++ trunk/LayoutTests/ChangeLog 2012-05-01 21:26:04 UTC (rev 115749)
@@ -1,3 +1,35 @@
+2012-05-01 Silvia Pfeiffer <[email protected]>
+
+ Audio controls have a 1px surplus outline coming from RenderImage::paintReplaced base class,
+ which needs overwriting. All layout tests with an audio element need a
+ visual update.
+ https://bugs.webkit.org/show_bug.cgi?id=84570
+
+ Reviewed by Eric Carlson.
+
+ * platform/chromium-linux/media/audio-controls-rendering-expected.png:
+ * platform/chromium-linux/media/audio-repaint-expected.png:
+ * platform/chromium-linux/media/controls-after-reload-expected.png:
+ * platform/chromium-linux/media/controls-layout-direction-expected.png:
+ * platform/chromium-linux/media/media-controls-clone-expected.png:
+ * platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png:
+ * platform/chromium-mac-leopard/media/audio-repaint-expected.png:
+ * platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
+ * platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png:
+ * platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
+ * platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png:
+ * platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png:
+ * platform/chromium-mac/media/audio-controls-rendering-expected.png:
+ * platform/chromium-mac/media/audio-repaint-expected.png:
+ * platform/chromium-mac/media/controls-after-reload-expected.png:
+ * platform/chromium-mac/media/controls-layout-direction-expected.png:
+ * platform/chromium-mac/media/media-controls-clone-expected.png:
+ * platform/chromium-win/media/audio-controls-rendering-expected.png:
+ * platform/chromium-win/media/audio-repaint-expected.png:
+ * platform/chromium-win/media/controls-after-reload-expected.png:
+ * platform/chromium-win/media/controls-layout-direction-expected.png:
+ * platform/chromium-win/media/media-controls-clone-expected.png:
+
2012-05-01 Aaron Colwell <[email protected]>
Temporarily removing tests for webkitSourceAddId() & webkitSourceRemoveId()
Modified: trunk/LayoutTests/platform/chromium-linux/media/audio-controls-rendering-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-linux/media/audio-repaint-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-linux/media/controls-layout-direction-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-linux/media/media-controls-clone-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac/media/audio-controls-rendering-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac/media/audio-repaint-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac/media/controls-after-reload-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac/media/controls-layout-direction-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac/media/media-controls-clone-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac-leopard/media/audio-repaint-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac-leopard/media/controls-after-reload-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/media/audio-repaint-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-win/media/audio-controls-rendering-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-win/media/audio-repaint-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-win/media/controls-after-reload-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-win/media/controls-layout-direction-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-win/media/media-controls-clone-expected.png
(Binary files differ)
Modified: trunk/Source/WebCore/ChangeLog (115748 => 115749)
--- trunk/Source/WebCore/ChangeLog 2012-05-01 21:21:53 UTC (rev 115748)
+++ trunk/Source/WebCore/ChangeLog 2012-05-01 21:26:04 UTC (rev 115749)
@@ -1,3 +1,19 @@
+2012-05-01 Silvia Pfeiffer <[email protected]>
+
+ Audio controls have a 1px surplus outline coming from RenderImage::paintReplaced base class,
+ which needs overwriting.
+ https://bugs.webkit.org/show_bug.cgi?id=84570
+
+ Reviewed by Eric Carlson.
+
+ No new tests - covered by existing audio rendering tests.
+
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::paintReplaced): Overwrite inherited function.
+ (WebCore):
+ * rendering/RenderMedia.h:
+ (RenderMedia):
+
2012-05-01 Terry Anderson <[email protected]>
Allow a pre-targeted node to be specified when dispatching a GestureTap event
Modified: trunk/Source/WebCore/rendering/RenderMedia.cpp (115748 => 115749)
--- trunk/Source/WebCore/rendering/RenderMedia.cpp 2012-05-01 21:21:53 UTC (rev 115748)
+++ trunk/Source/WebCore/rendering/RenderMedia.cpp 2012-05-01 21:26:04 UTC (rev 115749)
@@ -84,6 +84,10 @@
statePusher.pop();
}
+void RenderMedia::paintReplaced(PaintInfo&, const LayoutPoint&)
+{
+}
+
} // namespace WebCore
#endif
Modified: trunk/Source/WebCore/rendering/RenderMedia.h (115748 => 115749)
--- trunk/Source/WebCore/rendering/RenderMedia.h 2012-05-01 21:21:53 UTC (rev 115748)
+++ trunk/Source/WebCore/rendering/RenderMedia.h 2012-05-01 21:26:04 UTC (rev 115749)
@@ -56,6 +56,7 @@
virtual const char* renderName() const { return "RenderMedia"; }
virtual bool isMedia() const { return true; }
virtual bool isImage() const { return false; }
+ virtual void paintReplaced(PaintInfo&, const LayoutPoint&);
virtual bool requiresForcedStyleRecalcPropagation() const { return true; }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
