Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9f1b3cc7564972d2b7a5bc49db9faf850a7344b9
https://github.com/WebKit/WebKit/commit/9f1b3cc7564972d2b7a5bc49db9faf850a7344b9
Author: Przemyslaw Gorszkowski <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
M Source/WebCore/platform/gamepad/manette/ManetteGamepad.cpp
M Source/WebKit/WPEPlatform/wpe/WPEGamepadManette.cpp
Log Message:
-----------
[WPE][GTK] rumble does not work in case of libmanette 0.2.13
https://bugs.webkit.org/show_bug.cgi?id=323663
Reviewed by Carlos Garcia Campos.
Macros from libmanette: LIBMANETTE_CHECK_VERSION(deprecated) and
MANETTE_CHECK_VERSION evaluate to TRUE in case of greater than or
equal to. This caused that in case of version 0.2.13 wrong values
were passed to manette_device_rumble (normalized floating-point
rumble magnitudes) and it was rounded to 0 (guint16).
The normalized floating-point rumble magnitudes are demanded in
case of libmanette version >= 1.0.0.
Also deprecated macro is replaced with the new one.
No new tests.
* Source/WebCore/platform/gamepad/manette/ManetteGamepad.cpp:
(WebCore::ManetteGamepad::startRumble):
* Source/WebKit/WPEPlatform/wpe/WPEGamepadManette.cpp:
(wpeGamepadManetteRumble):
Canonical link: https://commits.webkit.org/320820@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
