Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 28da9c5a837bb8c3ccce2a061d41c87e980c0858
https://github.com/WebKit/WebKit/commit/28da9c5a837bb8c3ccce2a061d41c87e980c0858
Author: Yulun Wu <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
A LayoutTests/svg/animations/smil-seek-huge-repeat-count-crash-expected.txt
A LayoutTests/svg/animations/smil-seek-huge-repeat-count-crash.html
M Source/WebCore/svg/animation/SVGSMILElement.cpp
Log Message:
-----------
Clamp repeat count for SVG animation.
https://bugs.webkit.org/show_bug.cgi?id=318405
<rdar://176471329>
Reviewed by Said Abou-Hallawa.
This PR tightens the fix in 301404@main by clamping the repeat count to
an upper bound to prevent overflow.
Also coalesce the repeat events dispatched while seeking: rather than firing
one repeatEvent per skipped interval, dispatch a single repeatEvent. SVG 1.1
Animation defines a repeatEvent as raised each time the element repeats on a
normally-advancing timeline; how many events a discontinuous seek replays for
the intervals it skips is left to SMIL Animation's timing model, which does not
require one event per skipped interval (see also the WPT seeking-events-*
tests).
* LayoutTests/svg/animations/smil-seek-huge-repeat-count-crash-expected.txt:
Added.
* LayoutTests/svg/animations/smil-seek-huge-repeat-count-crash.html: Added.
* Source/WebCore/svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat const):
(WebCore::SVGSMILElement::progress):
Originally-landed-as: [email protected] (34249048d66d).
rdar://185366479
Canonical link: https://commits.webkit.org/320876@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
