Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0f0696c6d38131a1e4e5a9e2452474bf4f6a0ca3
https://github.com/WebKit/WebKit/commit/0f0696c6d38131a1e4e5a9e2452474bf4f6a0ca3
Author: Richard Robinson <[email protected]>
Date: 2026-09-11 (Fri, 11 Sep 2026)
Changed paths:
M Tools/Scripts/webkitpy/style/checker.py
A Tools/Scripts/webkitpy/style/checkers/swift_build_registration.py
A Tools/Scripts/webkitpy/style/checkers/swift_build_registration_unittest.py
M Tools/TestWebKitAPI/PlatformCocoa.cmake
Log Message:
-----------
[Swift Testing] Add a style checker rule to ensure tests aren't missed from
Xcode and/or CMake
https://bugs.webkit.org/show_bug.cgi?id=323947
rdar://187185767
Reviewed by Adrian Taylor.
It's super easy to have these accidentally mismatch, so ensure they don't with
this check.
And add some missing files to CMake that this check caught.
* Tools/Scripts/webkitpy/style/checker.py:
(_all_categories):
(StyleProcessor.do_association_check):
* Tools/Scripts/webkitpy/style/checkers/swift_build_registration.py: Added.
(build_file_entries):
(_imports_swiftui):
(_destination):
(_project_entry):
(_is_newly_added):
(SwiftBuildRegistrationChecker):
(SwiftBuildRegistrationChecker.check_registrations):
(SwiftBuildRegistrationChecker.check_registrations.report):
* Tools/Scripts/webkitpy/style/checkers/swift_build_registration_unittest.py:
Added.
(SwiftBuildRegistrationCheckerTest):
(SwiftBuildRegistrationCheckerTest.check):
(SwiftBuildRegistrationCheckerTest.added):
(SwiftBuildRegistrationCheckerTest.test_added_to_both_builds):
(SwiftBuildRegistrationCheckerTest.test_helper_added_to_both_builds):
(SwiftBuildRegistrationCheckerTest.test_added_to_xcode_only):
(SwiftBuildRegistrationCheckerTest.test_added_to_cmake_only):
(SwiftBuildRegistrationCheckerTest.test_added_to_neither_build):
(SwiftBuildRegistrationCheckerTest.test_path_with_spaces_is_quoted_in_the_xcode_project):
(SwiftBuildRegistrationCheckerTest.test_swiftui_test_is_not_required_in_cmake):
(SwiftBuildRegistrationCheckerTest.test_swiftui_test_is_still_required_in_the_xcode_project):
(SwiftBuildRegistrationCheckerTest.test_swiftui_named_in_a_comment_is_not_an_import):
(SwiftBuildRegistrationCheckerTest.test_similar_file_name_is_not_a_match):
(SwiftBuildRegistrationCheckerTest.test_modified_file_is_not_checked):
(SwiftBuildRegistrationCheckerTest.test_whole_file_check_is_not_an_addition):
(SwiftBuildRegistrationCheckerTest.test_folders_without_a_cmake_counterpart_are_out_of_scope):
(SwiftBuildRegistrationCheckerTest.test_non_swift_and_non_test_files_are_ignored):
(SwiftBuildRegistrationCheckerTest.test_removed_file_still_in_both_builds):
(SwiftBuildRegistrationCheckerTest.test_removed_file_absent_from_both_builds):
(SwiftBuildRegistrationCheckerTest.test_missing_project_file_reports_nothing):
(SwiftBuildRegistrationCheckerTest.test_project_file_without_swift_sources_reports_nothing):
(SwiftBuildRegistrationCheckerTest.test_missing_cmake_file_reports_nothing):
(SwiftBuildRegistrationCheckerTest.test_cmake_file_without_swift_sources_reports_nothing):
(SwiftBuildRegistrationCheckerTest.test_filtered_out_category_reports_nothing):
(SwiftBuildRegistrationCheckedInFilesTest):
(SwiftBuildRegistrationCheckedInFilesTest.setUp):
(SwiftBuildRegistrationCheckedInFilesTest.entries):
(SwiftBuildRegistrationCheckedInFilesTest.test_checked_in_swift_files_are_in_both_builds):
(SwiftBuildRegistrationCheckedInFilesTest.test_checked_in_swift_files_are_in_both_builds.is_swift):
* Tools/TestWebKitAPI/PlatformCocoa.cmake:
Canonical link: https://commits.webkit.org/320910@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
