Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8378080e2905835a921863258f21a44ef668ad22
      
https://github.com/WebKit/WebKit/commit/8378080e2905835a921863258f21a44ef668ad22
  Author: Alex Christensen <[email protected]>
  Date:   2026-09-11 (Fri, 11 Sep 2026)

  Changed paths:
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/platform/network/HTTPHeaderNames.in
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
    M Source/WebKit/NetworkProcess/NetworkResourceLoader.h
    M Source/WebKit/NetworkProcess/cache/NetworkCache.cpp
    M Source/WebKit/NetworkProcess/cache/NetworkCache.h
    R 
Source/WebKit/NetworkProcess/cache/NetworkCacheCompressionDictionaryEntry.cpp
    R 
Source/WebKit/NetworkProcess/cache/NetworkCacheCompressionDictionaryEntry.h
    M Source/WebKit/Sources.txt
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/glib/TestWebsiteData.cpp

  Log Message:
  -----------
  Revert 320786@main
https://bugs.webkit.org/show_bug.cgi?id=324006
rdar://187213201

Unreviewed.

It causes crashes on the main thread with this stack trace:

Thread 0 Crashed::
0   WebKit                                     0x10dda5754 
WTF::Detail::CallableWrapper<WebKit::NetworkCache::Cache::fetchData(bool, 
WTF::CompletionHandler<void (WTF::Vector<WebKit::WebsiteData::Entry, 0ul, 
WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&)>&&)::$_0, void, 
WebKit::NetworkCache::Cache::TraversalRecord 
const*>::call(WebKit::NetworkCache::Cache::TraversalRecord const*) + 1652
1   WebKit                                     0x10dda3f38 
WTF::Detail::CallableWrapper<WebKit::NetworkCache::Cache::traverseRecordsOfTypes(WTF::OptionSet<WebKit::NetworkCache::RecordType,
 (WTF::ConcurrencyTag)0>, std::__1::optional<WTF::String> const&, 
WTF::OptionSet<WebKit::NetworkCache::Storage::TraverseFlag, 
(WTF::ConcurrencyTag)0>, WTF::Function<void 
(WebKit::NetworkCache::Cache::TraversalRecord const*)>&&)::$_0, void, 
WebKit::NetworkCache::Storage::Record const*, 
WebKit::NetworkCache::Storage::RecordInfo 
const&>::call(WebKit::NetworkCache::Storage::Record const*, 
WebKit::NetworkCache::Storage::RecordInfo const&) + 116
2   WebKit                                     0x10ddca78c 
WTF::Detail::CallableWrapper<WebKit::NetworkCache::Storage::traverseInternal(WTF::String
 const&, WTF::String const&, 
WTF::OptionSet<WebKit::NetworkCache::Storage::TraverseFlag, 
(WTF::ConcurrencyTag)0>, WTF::Function<void 
(WebKit::NetworkCache::Storage::Record const*, 
WebKit::NetworkCache::Storage::RecordInfo 
const&)>&&)::$_0::operator()()::'lambda'(WTF::String const&, WTF::String 
const&, WTF::String const&, bool, WTF::String const&)::operator()(WTF::String 
const&, WTF::String const&, WTF::String const&, bool, WTF::String const&) 
const::'lambda'(auto, int), void, WebKit::NetworkCache::Data&&, 
int>::call(WebKit::NetworkCache::Data&&, int) + 408
3   WebKit                                     0x10e8f5e5c WTF::BlockPtr<void 
(bool, NSObject<OS_dispatch_data>*, int)> WTF::BlockPtr<void (bool, 
NSObject<OS_dispatch_data>*, 
int)>::fromCallable<WebKit::NetworkCache::IOChannel::read(unsigned long, 
unsigned long, WTF::Ref<WTF::WorkQueueBase, 
WTF::RawPtrTraits<WTF::WorkQueueBase>, 
WTF::DefaultRefDerefTraits<WTF::WorkQueueBase>>&&, WTF::Function<void 
(WebKit::NetworkCache::Data&&, 
int)>&&)::$_0>(WebKit::NetworkCache::IOChannel::read(unsigned long, unsigned 
long, WTF::Ref<WTF::WorkQueueBase, WTF::RawPtrTraits<WTF::WorkQueueBase>, 
WTF::DefaultRefDerefTraits<WTF::WorkQueueBase>>&&, WTF::Function<void 
(WebKit::NetworkCache::Data&&, int)>&&)::$_0)::'lambda'(void*, bool, 
NSObject<OS_dispatch_data>*, int)::__invoke(void*, bool, 
NSObject<OS_dispatch_data>*, int) + 108
4   libdispatch.dylib                          0x19078ada8 
___dispatch_operation_deliver_data_block_invoke + 152
5   libdispatch.dylib                          0x19075aa34 
_dispatch_call_block_and_release + 32

Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/glib/TestWebsiteData.cpp

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/network/HTTPHeaderNames.in:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::deleteWebsiteDataForOrigin):
(WebKit::deleteCacheRecordsForOrigin): Deleted.
* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::startNetworkLoad):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::tryStoreAsCacheEntry):
(WebKit::stringBareItem): Deleted.
(WebKit::NetworkResourceLoader::processUseAsDictionaryHeader): Deleted.
(WebKit::NetworkResourceLoader::storeCompressionDictionaryIfNeeded): Deleted.
* Source/WebKit/NetworkProcess/NetworkResourceLoader.h:
* Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::resourceType):
(WebKit::NetworkCache::Cache::makeCacheKey):
(WebKit::NetworkCache::Cache::retrieve):
(WebKit::NetworkCache::Cache::makeEntry):
(WebKit::NetworkCache::Cache::makeRedirectEntry):
(WebKit::NetworkCache::Cache::store):
(WebKit::NetworkCache::Cache::storeRedirect):
(WebKit::NetworkCache::Cache::remove):
(WebKit::NetworkCache::Cache::traverseRecords):
(WebKit::NetworkCache::Cache::dumpContentsToFile):
(WebKit::NetworkCache::Cache::fetchData):
(WebKit::NetworkCache::Cache::fetchOriginAccessTimes):
(WebKit::NetworkCache::Cache::deleteData):
(WebKit::NetworkCache::Cache::deleteDataForRegistrableDomains):
(WebKit::NetworkCache::recordTypeName): Deleted.
(WebKit::NetworkCache::Cache::storeCompressionDictionary): Deleted.
(WebKit::NetworkCache::Cache::TraversalRecord::type const): Deleted.
(WebKit::NetworkCache::Cache::TraversalRecord::url const): Deleted.
(WebKit::NetworkCache::Cache::traverseCompressionDictionaryRecords): Deleted.
(WebKit::NetworkCache::Cache::traverseRecordsOfTypes): Deleted.
* Source/WebKit/NetworkProcess/cache/NetworkCache.h:
* 
Source/WebKit/NetworkProcess/cache/NetworkCacheCompressionDictionaryEntry.cpp: 
Removed.
* Source/WebKit/NetworkProcess/cache/NetworkCacheCompressionDictionaryEntry.h: 
Removed.
* Source/WebKit/Sources.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/glib/TestWebsiteData.cpp:
(serverCallback):
(beforeAll):
(afterAll):
(diskCacheSize): Deleted.
(waitUntilDiskCacheSizeIsAtLeast): Deleted.
(waitUntilDiskCacheSizeIsAtMost): Deleted.
(loadCompressionDictionaryPage): Deleted.
(registerCompressionDictionary): Deleted.
(enableCompressionDictionary): Deleted.
(testWebsiteDataCompressionDictionary): Deleted.
(testWebsiteDataCompressionDictionaryForeignMatch): Deleted.
(testWebsiteDataCompressionDictionaryOtherOrigin): Deleted.

Canonical link: https://commits.webkit.org/320974@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to