Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f7bae2e3e663c54e292ed5331c810183638613d6
https://github.com/WebKit/WebKit/commit/f7bae2e3e663c54e292ed5331c810183638613d6
Author: Antoine Quint <[email protected]>
Date: 2026-09-11 (Fri, 11 Sep 2026)
Changed paths:
A
LayoutTests/webanimations/threaded-animations/updating-keyframes-to-unresolved-offsets-expected.txt
A
LayoutTests/webanimations/threaded-animations/updating-keyframes-to-unresolved-offsets.html
M Source/WebCore/animation/KeyframeEffect.cpp
Log Message:
-----------
[threaded-animations] updating keyframes of an accelerated animation's effect
to unresolved offsets should disable acceleration
https://bugs.webkit.org/show_bug.cgi?id=323967
rdar://187202092
Reviewed by Anne van Kesteren.
During analysis of bug 323307, Claude identified a lingering issue where
updating an acceleration animation
to use keyframes with unresolved offsets retained
acceleration but yielded a crash because we're not expecting
such keyframes in the remote layer tree.
We address this issue by resolving computed offsets prior to considering
acceleration for an effect. We also
add an assertion in `KeyframeEffect::acceleratedRepresentation()` to ensure
that by the time we request an
effect's accelerated representation the effect is indeed fine to accelerate,
which would have caught this
issue in the web process.
Test:
webanimations/threaded-animations/updating-keyframes-to-unresolved-offsets.html
*
LayoutTests/webanimations/threaded-animations/updating-keyframes-to-unresolved-offsets-expected.txt:
Added.
*
LayoutTests/webanimations/threaded-animations/updating-keyframes-to-unresolved-offsets.html:
Added.
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::setBlendingKeyframes):
(WebCore::KeyframeEffect::acceleratedRepresentation):
Canonical link:
https://flagged.apple.com:443/proxy?t2=Dm3M1d5XB8&o=aHR0cHM6Ly9jb21taXRzLndlYmtpdC5vcmcvMzIwOTQxQG1haW4=&emid=2ca2d10f-02ad-42b1-b867-0c0dcc12d07f&c=11
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
