Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5ed89fc0abf85e2613cd16c9c16ac66c6d64e17d
      
https://github.com/WebKit/WebKit/commit/5ed89fc0abf85e2613cd16c9c16ac66c6d64e17d
  Author: Tim Nguyen <[email protected]>
  Date:   2026-09-11 (Fri, 11 Sep 2026)

  Changed paths:
    M LayoutTests/TestExpectations
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/custom-highlight-universal-escaped-star.tentative-expected.txt
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/custom-highlight-universal-escaped-star.tentative.html
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/custom-highlight-universal-parsing-and-computed-style.tentative-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/custom-highlight-universal-parsing-and-computed-style.tentative.html
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/highlight-pseudo-parsing-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/parsing/pseudo-elements-valid-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/parsing/pseudo-elements-valid-with-classes-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/parsing/pseudo-elements-valid-with-classes.html
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/parsing/pseudo-elements-valid.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-escaped-star-specificity-expected.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-escaped-star-specificity.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-escaped-star-view-transition-group-expected.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-escaped-star-view-transition-group.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-get-computed-style-escaped-star-expected.txt
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-get-computed-style-escaped-star.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-match-escaped-star-expected.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-match-escaped-star.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-mismatch-escaped-star-expected.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-mismatch-escaped-star.html
    M Source/WebCore/css/CSSSelector.cpp
    M Source/WebCore/css/CSSSelector.h
    M Source/WebCore/css/SelectorChecker.cpp
    M Source/WebCore/css/parser/CSSSelectorParser.cpp
    M Source/WebCore/style/RuleSet.cpp

  Log Message:
  -----------
  [Custom Highlight] Support `::highlight(*)`
https://bugs.webkit.org/show_bug.cgi?id=323469
rdar://186700364

Reviewed by Megan Gardner.

::highlight(*) matches all highlights, with specificity 0.

emptyAtom() now represents * under the alias 
`universalPseudoElementNameAtom()`, to differentiate with \* which is 
represented by starAtom().

\* is now fixed in view transitions and tested:

Tests: 
imported/w3c/web-platform-tests/css/css-highlight-api/custom-highlight-universal-escaped-star.tentative.html
       
imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-escaped-star-specificity.html
       
imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-escaped-star-view-transition-group.html
       
imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-get-computed-style-escaped-star.html
       
imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-match-escaped-star.html
       
imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-mismatch-escaped-star.html

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/custom-highlight-universal-escaped-star.tentative-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/custom-highlight-universal-escaped-star.tentative.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/custom-highlight-universal-parsing-and-computed-style.tentative-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/highlight-pseudo-parsing-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/parsing/pseudo-elements-valid-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/parsing/pseudo-elements-valid-with-classes-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/parsing/pseudo-elements-valid-with-classes.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/parsing/pseudo-elements-valid.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-escaped-star-specificity-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-escaped-star-specificity.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-escaped-star-view-transition-group-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-escaped-star-view-transition-group.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-get-computed-style-escaped-star-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-get-computed-style-escaped-star.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-match-escaped-star-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-match-escaped-star.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-mismatch-escaped-star-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-mismatch-escaped-star.html:
 Added.
* Source/WebCore/css/CSSSelector.cpp:
(WebCore::simpleSelectorSpecificity):
(WebCore::CSSSelector::selectorText const):
* Source/WebCore/css/CSSSelector.h:
(WebCore::universalPseudoElementNameAtom):
* Source/WebCore/css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne const):
* Source/WebCore/css/parser/CSSSelectorParser.cpp:
(WebCore::CSSSelectorParser::consumePseudo):
(WebCore::CSSSelectorParser::parsePseudoElement):
* Source/WebCore/style/RuleSet.cpp:
(WebCore::Style::RuleSet::addRuleToBucket):
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/custom-highlight-universal-parsing-and-computed-style.tentative.html:

Canonical link: https://commits.webkit.org/320952@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to