Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5ce9bd51fec275272e0905986813894462c0bf4a
https://github.com/WebKit/WebKit/commit/5ce9bd51fec275272e0905986813894462c0bf4a
Author: Tim Horton <[email protected]>
Date: 2026-09-12 (Sat, 12 Sep 2026)
Changed paths:
M Source/WebKit/UIProcess/mac/AppKitGestures/WKAppKitGestureController.mm
M Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/AppKitGesturesTestsSupport.swift
M Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift
Log Message:
-----------
[AppKit Gestures] Click events don't carry pressed modifier keys
https://bugs.webkit.org/show_bug.cgi?id=324035
rdar://187270584
Reviewed by Abrar Rahman Protyasha.
Tests: Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift
* Source/WebKit/UIProcess/mac/AppKitGestures/WKAppKitGestureController.mm:
(-[WKAppKitGestureController _handleClickEnded:]):
Pass the held modifiers along from the gesture.
* Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/AppKitGesturesTestsSupport.swift:
(KeyboardModifier.hidUsage):
(KeyboardModifier.domName):
(RCPEventStreamComposer.holdingModifiers(_:_:)):
Add a recap composition method that holds the given modifier keys.
* Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift:
(AppKitGesturesTests.singleClickReportsHeldModifierKeys(_:)):
Add a test that ensures that we report the correct modifiers.
Canonical link: https://commits.webkit.org/320984@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
