Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2d4a4717af914f0abaaea207bee1aeac38c6383b
https://github.com/WebKit/WebKit/commit/2d4a4717af914f0abaaea207bee1aeac38c6383b
Author: Chris Dumez <[email protected]>
Date: 2026-09-13 (Sun, 13 Sep 2026)
Changed paths:
M Source/WTF/wtf/UUID.h
M Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp
M Tools/TestWebKitAPI/Tests/WTF/UUID.cpp
Log Message:
-----------
Share the canonical UUID string layout between WTF::UUID and FIDO AAGUID
logging
https://bugs.webkit.org/show_bug.cgi?id=324075
Reviewed by Darin Adler.
Follow-up to 320991@main, which gave CtapAuthenticator::aaguidForDebugging()
its own
copy of the 8-4-4-4-12 lowercase-hex layout that StringTypeAdapter<UUID>
already had,
rather than putting an AAGUID into a WTF::UUID it cannot legally hold.
The layout moves to StringTypeAdapter<UUIDCanonicalForm>, where
UUIDCanonicalForm is
128 bits that are UUID-shaped but may be a reserved value and so cannot be held
in a
UUID. StringTypeAdapter<UUID> derives from it and supplies the bits from the
UUID, so
UUID formats exactly as before. aaguidToString() keeps its std::span<const
std::byte,
16> and now only has to read the two halves big-endian, which is all its
grouping loop
was really for.
* Source/WTF/wtf/UUID.h:
* Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp:
(WebKit::aaguidToString):
* Tools/TestWebKitAPI/Tests/WTF/UUID.cpp:
(TEST(WTF, UUIDCanonicalForm)):
Canonical link: https://commits.webkit.org/321003@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
