Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a1848da321203d18234a90c743b362a75ae2092a
https://github.com/WebKit/WebKit/commit/a1848da321203d18234a90c743b362a75ae2092a
Author: Ahmad Saleem <[email protected]>
Date: 2026-09-13 (Sun, 13 Sep 2026)
Changed paths:
M Source/WebCore/Modules/webdriver/NavigatorWebDriver.cpp
M Source/WebCore/Modules/webdriver/NavigatorWebDriver.h
M Source/WebCore/platform/Supplementable.h
Log Message:
-----------
Remove dead Supplement<Navigator> machinery from NavigatorWebDriver
https://bugs.webkit.org/show_bug.cgi?id=323950
rdar://187187307
Reviewed by Chris Dumez.
navigator.webdriver is exposed via [ImplementedBy=NavigatorWebDriver] and
resolves to the static NavigatorWebDriver::webdriver(const Navigator&),
which forwards to the static isControlledByAutomation(). Neither needs an
instance, and NavigatorWebDriver::from() -- the only code that ever
constructed one -- has no callers anywhere. The class carried no state, so
the entire Supplement<Navigator> apparatus was dead.
Drop the Supplement base, from(), supplementName(), the constructor and
destructor, the TZone allocation, the isNavigatorWebDriver() type trait,
and the corresponding virtual in Supplementable.h. NavigatorWebDriver is
now a plain holder for the two static functions backing the IDL binding.
No change in behavior.
* Source/WebCore/Modules/webdriver/NavigatorWebDriver.cpp:
(WebCore::NavigatorWebDriver::from): Deleted.
* Source/WebCore/Modules/webdriver/NavigatorWebDriver.h:
(): Deleted.
(isType): Deleted.
* Source/WebCore/platform/Supplementable.h:
(WebCore::SupplementBase::isNavigatorUserActivation const):
(WebCore::SupplementBase::isNavigatorWebDriver const): Deleted.
Canonical link: https://commits.webkit.org/321027@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
