Title: [115804] trunk/Source/WebCore
- Revision
- 115804
- Author
- [email protected]
- Date
- 2012-05-02 01:51:50 -0700 (Wed, 02 May 2012)
Log Message
REGRESSION: Web Inspector doesn't show cookies anymore
https://bugs.webkit.org/show_bug.cgi?id=85349
Pass root node instead of DataGrid object to the "populateNode" method.
Added compiler annotations so that closure compiler catches such errors.
Reviewed by Pavel Feldman.
* inspector/front-end/CookiesTable.js:
(WebInspector.CookiesTable.prototype._rebuildTable):
* inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.addFrameError):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (115803 => 115804)
--- trunk/Source/WebCore/ChangeLog 2012-05-02 08:29:52 UTC (rev 115803)
+++ trunk/Source/WebCore/ChangeLog 2012-05-02 08:51:50 UTC (rev 115804)
@@ -1,3 +1,18 @@
+2012-05-02 Yury Semikhatsky <[email protected]>
+
+ REGRESSION: Web Inspector doesn't show cookies anymore
+ https://bugs.webkit.org/show_bug.cgi?id=85349
+
+ Pass root node instead of DataGrid object to the "populateNode" method.
+ Added compiler annotations so that closure compiler catches such errors.
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/CookiesTable.js:
+ (WebInspector.CookiesTable.prototype._rebuildTable):
+ * inspector/front-end/NetworkRequest.js:
+ (WebInspector.NetworkRequest.prototype.addFrameError):
+
2012-05-02 Dongwoo Im <[email protected]>
[EFL] Implement the Web Audio API feature.
Modified: trunk/Source/WebCore/inspector/front-end/CookiesTable.js (115803 => 115804)
--- trunk/Source/WebCore/inspector/front-end/CookiesTable.js 2012-05-02 08:29:52 UTC (rev 115803)
+++ trunk/Source/WebCore/inspector/front-end/CookiesTable.js 2012-05-02 08:51:50 UTC (rev 115804)
@@ -118,10 +118,14 @@
this._populateNode(groupNode, item.cookies);
groupNode.expand();
} else
- this._populateNode(this._dataGrid, item.cookies);
+ this._populateNode(this._dataGrid.rootNode(), item.cookies);
}
},
+ /**
+ * @param {WebInspector.DataGridNode} parentNode
+ * @param {Array.<PageAgent.Cookie>} cookies
+ */
_populateNode: function(parentNode, cookies)
{
var selectedCookie = this.selectedCookie;
Modified: trunk/Source/WebCore/inspector/front-end/NetworkRequest.js (115803 => 115804)
--- trunk/Source/WebCore/inspector/front-end/NetworkRequest.js 2012-05-02 08:29:52 UTC (rev 115803)
+++ trunk/Source/WebCore/inspector/front-end/NetworkRequest.js 2012-05-02 08:51:50 UTC (rev 115804)
@@ -830,7 +830,7 @@
*/
addFrameError: function(errorMessage, time)
{
- errorObject = {};
+ var errorObject = {};
errorObject.errorMessage = errorMessage;
errorObject.time = time;
this._pushFrame(errorObject);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
