Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e1d1defe5d71e3f6e63bc229c57ea5c031184c7b
https://github.com/WebKit/WebKit/commit/e1d1defe5d71e3f6e63bc229c57ea5c031184c7b
Author: Dominic Mazzoni <[email protected]>
Date: 2026-09-15 (Tue, 15 Sep 2026)
Changed paths:
A
LayoutTests/accessibility/isolated-tree/mac/delete-notification-text-marker-expected.txt
A
LayoutTests/accessibility/isolated-tree/mac/delete-notification-text-marker.html
A LayoutTests/accessibility/mac/delete-notification-text-marker-expected.txt
A LayoutTests/accessibility/mac/delete-notification-text-marker.html
M Source/WebCore/editing/TypingCommand.cpp
M Source/WebCore/editing/TypingCommand.h
Log Message:
-----------
AX: The AXValueChanged notification includes a stale text marker after a
delete edit operation
https://bugs.webkit.org/show_bug.cgi?id=324217
rdar://187439810
Reviewed by Tyler Wilcock.
When the value of a text field changes, we post an AXValueChanged notificaiton
that contains additional fields with information, in particular
AXTextChangeValueStartMarker.
The accessibility notification has to be posted after the editing operation
completes, otherwise under some circumstances (such as deleting certain
generated
newlines) the text marker becomes invalid.
Tests: accessibility/isolated-tree/mac/delete-notification-text-marker.html
accessibility/mac/delete-notification-text-marker.html
*
LayoutTests/accessibility/isolated-tree/mac/delete-notification-text-marker-expected.txt:
Added.
*
LayoutTests/accessibility/isolated-tree/mac/delete-notification-text-marker.html:
Added.
* LayoutTests/accessibility/mac/delete-notification-text-marker-expected.txt:
Added.
* LayoutTests/accessibility/mac/delete-notification-text-marker.html: Added.
* Source/WebCore/editing/TypingCommand.cpp:
(WebCore::TypingCommand::recordDeletionForAccessibility):
(WebCore::TypingCommand::postTextStateChangeNotificationForDeletion):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
* Source/WebCore/editing/TypingCommand.h:
Canonical link: https://commits.webkit.org/321177@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
