Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f4318a859b670248dc442e1d75b597cefbb8ccc2
https://github.com/WebKit/WebKit/commit/f4318a859b670248dc442e1d75b597cefbb8ccc2
Author: Alan Baradlay <[email protected]>
Date: 2026-09-15 (Tue, 15 Sep 2026)
Changed paths:
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderBoxInlines.h
M Source/WebCore/rendering/RenderBoxModelObject.cpp
M Source/WebCore/rendering/RenderBoxModelObject.h
M Source/WebCore/rendering/RenderInline.cpp
M Source/WebCore/rendering/RenderInline.h
M Source/WebCore/style/StyleExtractorCustom.h
Log Message:
-----------
[cleanup] paddingBoxLogicalWidth() and paddingBoxLogicalHeight() work on
fragmented and non-fragmented boxes
https://bugs.webkit.org/show_bug.cgi?id=324064
<rdar://problem/187295896>
Reviewed by Antti Koivisto.
1.
RenderInline::innerPaddingBox{Width,Height} were the logical padding box
extents under another name.
The first measures the inline axis from the first fragment's padding box start
to the last fragment's padding box end, the second the block axis of the line
boxes minus the borders, which is what RenderBox spells
paddingBoxLogical{Width,Height}.
2. They become the RenderBoxModelObject implementation, with RenderBox
overriding.
RenderBox's pair moves out of RenderBoxInlines.h, since a virtual defined in an
inlines header needs its definition in every translation unit.
containingBlockRangeForPositioned() and the inset extractor stop asking whether
the container is a RenderInline.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::paddingBoxLogicalWidth const):
(WebCore::RenderBox::paddingBoxLogicalHeight const):
(WebCore::RenderBox::containingBlockRangeForPositioned const):
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderBoxInlines.h:
*
Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paddingBoxLogicalWidth const):
(WebCore::RenderBoxModelObject::paddingBoxLogicalHeight const):
* Source/WebCore/rendering/RenderBoxModelObject.h:
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::innerPaddingBoxWidth const): Deleted.
(WebCore::RenderInline::innerPaddingBoxHeight const): Deleted.
* Source/WebCore/rendering/RenderInline.h:
* Source/WebCore/style/StyleExtractorCustom.h:
Canonical link:
https://flagged.apple.com:443/proxy?t2=Dh9g3j8oI1&o=aHR0cHM6Ly9jb21taXRzLndlYmtpdC5vcmcvMzIxMjA3QG1haW4=&emid=d9be2986-6d65-43ce-beb5-d9fdb27b4bb2&c=11
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
