Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7a93c60b28a8fd883af2bb488a3c49e19b6f090d
https://github.com/WebKit/WebKit/commit/7a93c60b28a8fd883af2bb488a3c49e19b6f090d
Author: Brent Fulgham <[email protected]>
Date: 2026-09-15 (Tue, 15 Sep 2026)
Changed paths:
M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp
M Source/WebCore/platform/graphics/Font.cpp
M Source/WebCore/platform/graphics/Font.h
M Source/WebCore/platform/graphics/FontBase.h
M Source/WebCore/platform/graphics/FontInlines.h
M Tools/TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp
Log Message:
-----------
Remove SyntheticBoldInclusion enum and related dead code
https://bugs.webkit.org/show_bug.cgi?id=324291
rdar://187521972
Reviewed by Vitor Roriz and Zak Ridouh.
Follow-up to the Bug 201725, which stopped synthetic bold from widening
measured advances.
SyntheticBoldInclusion existed so a caller could ask Font::widthForGlyph() or
FontBase::spaceWidth() to fold the synthetic bold offset into the value it
returned.
No call site ever named Incorporate; it was reachable only as the default
argument of
those two functions, and the handful of sites that mentioned the enum at all
were
opting out with Exclude. Now that both defaults are Exclude, Incorporate is
unreachable
and both functions take the same branch everywhere.
Remove the enum, drop the parameter from the two functions, and delete the
now-redundant
Exclude arguments. No behavior change.
* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::fallbackFontsForRunWithIterator): The comment here explained
why this
call opted out of the synthetic bold expansion. There is no longer anything to
opt out of.
* Source/WebCore/platform/graphics/Font.cpp:
(WebCore::Font::platformGlyphInit):
* Source/WebCore/platform/graphics/Font.h:
* Source/WebCore/platform/graphics/FontBase.h:
(WebCore::FontBase::spaceWidth const):
* Source/WebCore/platform/graphics/FontInlines.h:
(WebCore::Font::widthForGlyph const):
* Tools/TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
Canonical link: https://commits.webkit.org/321223@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
