Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4e7a14b5f9619c1212d11a414c9c88816d3ee74d
https://github.com/WebKit/WebKit/commit/4e7a14b5f9619c1212d11a414c9c88816d3ee74d
Author: Ahmad Saleem <[email protected]>
Date: 2026-09-16 (Wed, 16 Sep 2026)
Changed paths:
M Source/WebCore/Modules/webdriver/NavigatorWebDriver.cpp
M Source/WebCore/Modules/webdriver/NavigatorWebDriver.h
Log Message:
-----------
Remove unnecessary repeated Frame::page() call in
NavigatorWebDriver::isControlledByAutomation()
https://bugs.webkit.org/show_bug.cgi?id=323946
rdar://187185385
Reviewed by Chris Dumez.
NavigatorWebDriver::isControlledByAutomation() called frame->page() twice
— once in the null guard and again to read isControlledByAutomation().
Compute page() once into a local and reuse it.
Hold the frame and page in RefPtr rather than raw pointers, and drop the
NODELETE annotations from the declarations, so the code satisfies Safer
C++ without suppressing its checks. With NODELETE gone, the header no
longer needs <wtf/Compiler.h>, so remove that include.
No change in behavior.
* Source/WebCore/Modules/webdriver/NavigatorWebDriver.cpp:
(WebCore::NavigatorWebDriver::isControlledByAutomation):
* Source/WebCore/Modules/webdriver/NavigatorWebDriver.h:
Canonical link: https://commits.webkit.org/321247@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
