Title: [115817] trunk/Source/WebCore
- Revision
- 115817
- Author
- [email protected]
- Date
- 2012-05-02 05:07:34 -0700 (Wed, 02 May 2012)
Log Message
Web Inspector: Cannot read property 'length' of undefined TextEditorModel.js:467
https://bugs.webkit.org/show_bug.cgi?id=85360
Reviewed by Yury Semikhatsky.
Added the undo/redo stack length checks.
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (115816 => 115817)
--- trunk/Source/WebCore/ChangeLog 2012-05-02 12:04:46 UTC (rev 115816)
+++ trunk/Source/WebCore/ChangeLog 2012-05-02 12:07:34 UTC (rev 115817)
@@ -1,5 +1,17 @@
2012-05-02 Pavel Feldman <[email protected]>
+ Web Inspector: Cannot read property 'length' of undefined TextEditorModel.js:467
+ https://bugs.webkit.org/show_bug.cgi?id=85360
+
+ Reviewed by Yury Semikhatsky.
+
+ Added the undo/redo stack length checks.
+
+ * inspector/front-end/TextEditorModel.js:
+ (WebInspector.TextEditorModel.endsWithBracketRegex.):
+
+2012-05-02 Pavel Feldman <[email protected]>
+
WebInspector: Scripts panel editor dirty state is cleared when the tab with editor is closed.
https://bugs.webkit.org/show_bug.cgi?id=85361
Modified: trunk/Source/WebCore/inspector/front-end/TextEditorModel.js (115816 => 115817)
--- trunk/Source/WebCore/inspector/front-end/TextEditorModel.js 2012-05-02 12:04:46 UTC (rev 115816)
+++ trunk/Source/WebCore/inspector/front-end/TextEditorModel.js 2012-05-02 12:07:34 UTC (rev 115817)
@@ -404,6 +404,9 @@
*/
undo: function(beforeCallback, afterCallback)
{
+ if (!this._undoStack.length)
+ return;
+
this._markRedoableState();
this._inUndo = true;
@@ -420,6 +423,8 @@
*/
redo: function(beforeCallback, afterCallback)
{
+ if (!this._redoStack || !this._redoStack.length)
+ return;
this.markUndoableState();
this._inRedo = true;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
