Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 43d296eeb4c9a4f87d9c90f2ebfa1220da4450d4
https://github.com/WebKit/WebKit/commit/43d296eeb4c9a4f87d9c90f2ebfa1220da4450d4
Author: Kiet Ho <[email protected]>
Date: 2026-09-16 (Wed, 16 Sep 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
Log Message:
-----------
[Site Isolation] Rewrite color picker location API tests
rdar://187244531
https://bugs.webkit.org/show_bug.cgi?id=324008
Reviewed by Abrar Rahman Protyasha.
SiteIsolation.ColorInputPickerLocation and
SiteIsolation.ColorInputPickerLocation2
are basically the same tests, just with different inner frame pages, so this
patch
moves the common logic into testColorPickerPopoverLocation.
Also only checks the location of the color picker popover, since that is
computed
using contentsToMainFrameView, which is our test target. The size is identical
to
the size of the <input type='color'> element, so nothing interesting here.
Also renames the tests to be more descriptive.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm:
(TestWebKitAPI::(SiteIsolation, ColorInputPickerLocationInCrossSiteIframe)):
(TestWebKitAPI::(SiteIsolation,
ColorInputPickerLocationInScrolledCrossSiteIframe)):
(TestWebKitAPI::(SiteIsolation, ColorInputPickerLocation)): Deleted.
(TestWebKitAPI::(SiteIsolation, ColorInputPickerLocation2)): Deleted.
Canonical link: https://commits.webkit.org/321261@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
