Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d6e1b69abc442d4190a925517e4e6102ffbe76d1
https://github.com/WebKit/WebKit/commit/d6e1b69abc442d4190a925517e4e6102ffbe76d1
Author: Yusuke Suzuki <[email protected]>
Date: 2026-09-16 (Wed, 16 Sep 2026)
Changed paths:
R LayoutTests/fast/misc/resources/test-observegc.js
R LayoutTests/fast/misc/test-observegc-expected.txt
R LayoutTests/fast/misc/test-observegc.html
M LayoutTests/resources/gc.js
M LayoutTests/storage/indexeddb/cursor-leak-expected.txt
M LayoutTests/storage/indexeddb/cursor-leak-private-expected.txt
M LayoutTests/storage/indexeddb/cursor-leak-private.html
M LayoutTests/storage/indexeddb/cursor-leak.html
M LayoutTests/storage/indexeddb/cursor-request-cycle-expected.txt
M LayoutTests/storage/indexeddb/cursor-request-cycle-private-expected.txt
M LayoutTests/storage/indexeddb/cursor-request-cycle-private.html
M LayoutTests/storage/indexeddb/cursor-request-cycle.html
M LayoutTests/storage/indexeddb/modern/leak-1-expected.txt
M LayoutTests/storage/indexeddb/modern/leak-1.html
M LayoutTests/storage/indexeddb/modern/resources/leak-1.js
M LayoutTests/storage/indexeddb/request-leak-expected.txt
M LayoutTests/storage/indexeddb/request-leak-private-expected.txt
M LayoutTests/storage/indexeddb/request-leak-private.html
M LayoutTests/storage/indexeddb/request-leak.html
M LayoutTests/storage/indexeddb/resources/cursor-leak.js
M LayoutTests/storage/indexeddb/resources/cursor-request-cycle.js
M LayoutTests/storage/indexeddb/resources/request-leak.js
M LayoutTests/storage/indexeddb/resources/result-request-cycle.js
M LayoutTests/storage/indexeddb/resources/value-cursor-cycle.js
M LayoutTests/storage/indexeddb/result-request-cycle-expected.txt
M LayoutTests/storage/indexeddb/result-request-cycle.html
M LayoutTests/storage/indexeddb/value-cursor-cycle-expected.txt
M LayoutTests/storage/indexeddb/value-cursor-cycle.html
M LayoutTests/svg/animations/svg-element-attribute-changed-crash.html
M LayoutTests/webaudio/offlineaudiocontext-gc.html
M Source/WebCore/CMakeLists.txt
M Source/WebCore/DerivedSources-input.xcfilelist
M Source/WebCore/DerivedSources-output.xcfilelist
M Source/WebCore/DerivedSources.make
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
R Source/WebCore/testing/GCObservation.cpp
R Source/WebCore/testing/GCObservation.h
R Source/WebCore/testing/GCObservation.idl
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
Log Message:
-----------
Remove GCObservation
https://bugs.webkit.org/show_bug.cgi?id=324367
rdar://187603540
Reviewed by Keith Miller.
Remove GCObservation from WebCore. This is internal object introduced
for testing purpose before we didn't have GC related mechanism. But now
ECMAScript offers WeakRef, so we do not need this special object.
Removing it and replacing existing tests with WeakRef.
We also rewrote these tests to follow to our guidance (224541@main).
These tests are written in a wrong way that it is not assuming
conservative GC and assuming deterministic behavior. This patch fixes them.
* LayoutTests/fast/misc/resources/test-observegc.js: Removed.
* LayoutTests/fast/misc/test-observegc-expected.txt: Removed.
* LayoutTests/fast/misc/test-observegc.html: Removed.
* LayoutTests/resources/gc.js:
(turnEventLoop):
(async gcUntil):
* LayoutTests/storage/indexeddb/cursor-leak-expected.txt:
* LayoutTests/storage/indexeddb/cursor-leak-private-expected.txt:
* LayoutTests/storage/indexeddb/cursor-leak-private.html:
* LayoutTests/storage/indexeddb/cursor-leak.html:
* LayoutTests/storage/indexeddb/cursor-request-cycle-expected.txt:
* LayoutTests/storage/indexeddb/cursor-request-cycle-private-expected.txt:
* LayoutTests/storage/indexeddb/cursor-request-cycle-private.html:
* LayoutTests/storage/indexeddb/cursor-request-cycle.html:
* LayoutTests/storage/indexeddb/modern/leak-1-expected.txt:
* LayoutTests/storage/indexeddb/modern/leak-1.html:
* LayoutTests/storage/indexeddb/modern/resources/leak-1.js:
(forEachDatabase):
(async test):
(prepareDatabase): Deleted.
(testSucceeded): Deleted.
(sleep): Deleted.
* LayoutTests/storage/indexeddb/request-leak-expected.txt:
* LayoutTests/storage/indexeddb/request-leak-private-expected.txt:
* LayoutTests/storage/indexeddb/request-leak-private.html:
* LayoutTests/storage/indexeddb/request-leak.html:
* LayoutTests/storage/indexeddb/resources/cursor-leak.js:
(onOpen.tx.oncomplete): Deleted.
(): Deleted.
* LayoutTests/storage/indexeddb/resources/cursor-request-cycle.js:
(continuedCursorSuccess):
(async onTransactionComplete):
(isAnyCollected): Deleted.
(onTransactionComplete): Deleted.
* LayoutTests/storage/indexeddb/resources/request-leak.js:
(onOpen.tx.oncomplete.async onTransactionComplete):
(onOpen.tx.oncomplete): Deleted.
(onOpen): Deleted.
* LayoutTests/storage/indexeddb/resources/result-request-cycle.js:
* LayoutTests/storage/indexeddb/resources/value-cursor-cycle.js:
(onOpen.cursorRequest.onsuccess): Deleted.
(): Deleted.
* LayoutTests/storage/indexeddb/result-request-cycle-expected.txt:
* LayoutTests/storage/indexeddb/result-request-cycle.html:
* LayoutTests/storage/indexeddb/value-cursor-cycle-expected.txt:
* LayoutTests/storage/indexeddb/value-cursor-cycle.html:
* LayoutTests/svg/animations/svg-element-attribute-changed-crash.html:
* LayoutTests/webaudio/offlineaudiocontext-gc.html:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/testing/GCObservation.cpp: Removed.
* Source/WebCore/testing/GCObservation.h: Removed.
* Source/WebCore/testing/GCObservation.idl: Removed.
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::observeGC): Deleted.
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
Canonical link: https://commits.webkit.org/321303@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
