Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1aa6a33856f24134da217eb74d03e208d8885e67
https://github.com/WebKit/WebKit/commit/1aa6a33856f24134da217eb74d03e208d8885e67
Author: Chris Dumez <[email protected]>
Date: 2026-09-17 (Thu, 17 Sep 2026)
Changed paths:
M Source/JavaScriptCore/runtime/BundlePath.h
M Source/JavaScriptCore/runtime/BundlePath.mm
M Source/WTF/wtf/text/CString.h
M Source/WebCore/platform/mac/UserActivityMac.mm
M Source/WebCore/rendering/mac/RenderThemeMac.mm
M Source/WebKit/Platform/cocoa/WebPrivacyHelpers.mm
M Source/WebKit/Shared/Cocoa/CoreIPCNSURLRequest.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm
M Source/WebKit/UIProcess/Cocoa/PreferenceObserver.mm
M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm
M Source/WebKit/webpushd/webpushtool/WebPushToolConnection.mm
M Tools/TestWebKitAPI/Tests/WTF/cocoa/CStringCocoa.mm
Log Message:
-----------
Stop using deprecated CString in WebPrivacyHelpers.mm
https://bugs.webkit.org/show_bug.cgi?id=324330
Reviewed by Wenson Hsieh.
Stop using deprecated CString in WebPrivacyHelpers.mm, use UTF8CString
instead since the strings are UTF8-encoded.
Add a UTF8CString constructor taking an NSString, the missing reverse of
CStringWithEncoding::createNSString(), so that call sites do not have to
spell out byteCast<char8_t>(string.UTF8String). It converts nil to a null
string, like String(NSString *), and is only offered for UTF-8 since
-cStringUsingEncoding: returns null for a string Latin-1 cannot represent.
Adopt it everywhere in the tree that built an owning UTF-8 string from an
NSString, which also removes a UTF-16 round trip from the call sites that
went through String(NSString *).utf8().
* Source/JavaScriptCore/runtime/BundlePath.h:
* Source/JavaScriptCore/runtime/BundlePath.mm:
(JSC::bundlePath):
* Source/WTF/wtf/text/CString.h:
(WTF::CStringWithEncoding::CStringWithEncoding):
* Source/WebCore/platform/mac/UserActivityMac.mm:
(WebCore::UserActivity::Impl::beginActivity):
(WebCore::UserActivity::Impl::endActivity):
* Source/WebCore/rendering/mac/RenderThemeMac.mm:
(WebCore::iconForAttachment):
* Source/WebKit/Platform/cocoa/WebPrivacyHelpers.mm:
(WebKit::TrackerAddressLookupInfo::owner const):
(WebKit::TrackerAddressLookupInfo::host const):
(WebKit::TrackerDomainLookupInfo::TrackerDomainLookupInfo):
(WebKit::TrackerDomainLookupInfo::owner const):
(WebKit::configureForAdvancedPrivacyProtections):
* Source/WebKit/Shared/Cocoa/CoreIPCNSURLRequest.mm:
(WebKit::populateAppProperties):
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(+[WKWebsiteDataStore dataStoreForIdentifier:]):
* Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:
(-[_WKWebsiteDataStoreConfiguration initWithIdentifier:]):
* Source/WebKit/UIProcess/Cocoa/PreferenceObserver.mm:
(-[WKPreferenceObserver init]):
* Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::ProcessLauncher::launchProcess):
* Source/WebKit/webpushd/webpushtool/WebPushToolConnection.mm:
(WebPushTool::Connection::connectToService):
* Tools/TestWebKitAPI/Tests/WTF/cocoa/CStringCocoa.mm:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/321312@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
