Title: [115825] trunk
- Revision
- 115825
- Author
- [email protected]
- Date
- 2012-05-02 07:08:30 -0700 (Wed, 02 May 2012)
Log Message
[GTK] drag&drop related failures
https://bugs.webkit.org/show_bug.cgi?id=84675
Reviewed by Philippe Normand.
Tools:
Rather than checking options to see whether we're running pixel tests
the pixel_tests argument passed to GtkDriver._start should be used as
it also covers cases when pixel tests should be run because of testing
reftests. This again creates different Xvfb processes with proper
display IDs for a worker that's performing both ordinary and pixel
tests, as was the case before changes made in r114788.
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver._start):
LayoutTests:
Remove test cases from expectations that are now passing.
* platform/gtk/test_expectations.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (115824 => 115825)
--- trunk/LayoutTests/ChangeLog 2012-05-02 14:01:50 UTC (rev 115824)
+++ trunk/LayoutTests/ChangeLog 2012-05-02 14:08:30 UTC (rev 115825)
@@ -1,3 +1,14 @@
+2012-05-02 Zan Dobersek <[email protected]>
+
+ [GTK] drag&drop related failures
+ https://bugs.webkit.org/show_bug.cgi?id=84675
+
+ Reviewed by Philippe Normand.
+
+ Remove test cases from expectations that are now passing.
+
+ * platform/gtk/test_expectations.txt:
+
2012-05-02 Andrey Kosyakov <[email protected]>
Unreviewed. Removed entries for 4 media tests that pass now.
Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (115824 => 115825)
--- trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-05-02 14:01:50 UTC (rev 115824)
+++ trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-05-02 14:08:30 UTC (rev 115825)
@@ -484,25 +484,6 @@
BUGWK84037 : fast/text/international/spaces-combined-in-vertical-text.html = PASS TEXT
-BUGWK84675 : editing/pasteboard/4947130.html = TEXT PASS
-BUGWK84675 : editing/pasteboard/dataTransfer-setData-getData.html = TEXT PASS
-BUGWK84675 : editing/pasteboard/drag-and-drop-image-contenteditable.html = TEXT PASS
-BUGWK84675 : editing/pasteboard/drag-and-drop-inputimage-contenteditable.html = TEXT PASS
-BUGWK84675 : editing/pasteboard/drag-and-drop-objectimage-contenteditable.html = TEXT PASS
-BUGWK84675 : editing/pasteboard/drag-drop-input-textarea.html = TEXT PASS
-BUGWK84675 : editing/pasteboard/drag-drop-modifies-page.html = TEXT PASS
-BUGWK84675 : editing/pasteboard/drag-drop-url-text.html = TEXT PASS
-BUGWK84675 : editing/pasteboard/drag-image-in-about-blank-frame.html = TEXT PASS
-BUGWK84675 : editing/pasteboard/drag-selected-image-to-contenteditable.html = TEXT PASS
-BUGWK84675 : editing/pasteboard/drop-inputtext-acquires-style.html = TEXT PASS
-BUGWK84675 : editing/pasteboard/drop-link.html = TEXT PASS
-BUGWK84675 : editing/pasteboard/drop-text-events.html = TEXT PASS
-BUGWK84675 : editing/pasteboard/drop-text-without-selection.html = TEXT PASS
-BUGWK84675 : editing/pasteboard/file-drag-to-editable.html = TEXT PASS
-BUGWK84675 : editing/pasteboard/file-input-files-access.html = TEXT PASS
-BUGWK84675 : editing/pasteboard/get-data-text-plain-drop.html = TEXT PASS
-BUGWK84675 : editing/pasteboard/subframe-dragndrop-1.html = TEXT PASS
-
BUGWK84700 : fast/dom/Window/window-postmessage-clone.html = PASS TEXT
BUGWK84700 : fast/dom/Window/window-postmessage-clone-frames.html = PASS TEXT
@@ -1528,13 +1509,6 @@
BUGWK84378 : media/track/track-cue-rendering-snap-to-lines-not-set.html = FAIL
-BUGWK84675 : fast/forms/drag-into-textarea.html = TEXT
-BUGWK84675 : fast/forms/drag-out-of-textarea.html = TEXT
-BUGWK84675 : fast/forms/file/get-file-upload.html = TEXT
-BUGWK84675 : fast/forms/file/input-file-re-render.html = TEXT
-BUGWK84675 : fast/forms/file/recover-file-input-in-unposted-form.html = TEXT
-BUGWK84675 : fast/lists/drag-into-marker.html = TEXT
-
BUGWK84678 : fast/spatial-navigation/snav-container-white-space.html = TEXT
BUGWK84678 : fast/spatial-navigation/snav-fully-aligned-horizontally.html = TEXT
BUGWK84678 : fast/spatial-navigation/snav-iframe-no-scrollable-content.html = TEXT
Modified: trunk/Tools/ChangeLog (115824 => 115825)
--- trunk/Tools/ChangeLog 2012-05-02 14:01:50 UTC (rev 115824)
+++ trunk/Tools/ChangeLog 2012-05-02 14:08:30 UTC (rev 115825)
@@ -1,3 +1,20 @@
+2012-05-02 Zan Dobersek <[email protected]>
+
+ [GTK] drag&drop related failures
+ https://bugs.webkit.org/show_bug.cgi?id=84675
+
+ Reviewed by Philippe Normand.
+
+ Rather than checking options to see whether we're running pixel tests
+ the pixel_tests argument passed to GtkDriver._start should be used as
+ it also covers cases when pixel tests should be run because of testing
+ reftests. This again creates different Xvfb processes with proper
+ display IDs for a worker that's performing both ordinary and pixel
+ tests, as was the case before changes made in r114788.
+
+ * Scripts/webkitpy/layout_tests/port/gtk.py:
+ (GtkDriver._start):
+
2012-05-02 Simon Hausmann <[email protected]>
[Qt] Enable device orientation/motion with Qt 5
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (115824 => 115825)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2012-05-02 14:01:50 UTC (rev 115824)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2012-05-02 14:08:30 UTC (rev 115825)
@@ -52,7 +52,7 @@
# DriverProxy creates two drivers, one for normal and the other for ref tests. Both have
# the same worker number, so this prevents them from using the same Xvfb instance.
display_id = self._worker_number * 2 + running_displays
- if self._port.get_option('pixel_tests'):
+ if pixel_tests:
display_id += 1
run_xvfb = ["Xvfb", ":%d" % (display_id), "-screen", "0", "800x600x24", "-nolisten", "tcp"]
with open(os.devnull, 'w') as devnull:
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
