Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ef7edc36e8e654f6d7531e8e22cca99315062b86
https://github.com/WebKit/WebKit/commit/ef7edc36e8e654f6d7531e8e22cca99315062b86
Author: Claudio Saavedra <[email protected]>
Date: 2026-09-18 (Fri, 18 Sep 2026)
Changed paths:
M Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp
M Source/WebCore/accessibility/atspi/AccessibilityAtspi.h
M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h
M Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp
Log Message:
-----------
[ATSPI] Return UTF8CString from the accessibility text producers
https://bugs.webkit.org/show_bug.cgi?id=324532
Reviewed by Chris Dumez.
AccessibilityObjectAtspi::name(), description(), text() and textAtOffset()
build their result from String::utf8() or g_utf8_substring(), and every
consumer hands it to D-Bus, which mandates UTF-8. Returning a bare CString
dropped that encoding at the return statement. Return UTF8CString instead, and
take one in AccessibilityAtspi::textChanged(), whose callers already pass a
String::utf8() result.
This also fixes WebKitTestRunner's AXTitle and AXDescription output for
non-ASCII names: makeString() decodes a span<const char> as Latin-1, and now
receives the span<const char8_t> it needs to decode UTF-8.
* Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp:
(WebCore::AccessibilityAtspi::textChanged):
* Source/WebCore/accessibility/atspi/AccessibilityAtspi.h:
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::name const):
(WebCore::AccessibilityObjectAtspi::description const):
(WebCore::AccessibilityObjectAtspi::serialize const):
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h:
* Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::text const):
(WebCore::AccessibilityObjectAtspi::textAtOffset const):
Canonical link: https://commits.webkit.org/321375@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
