Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 19ac18d5d05c20343fddb8a809dca7490b76ef2e
https://github.com/WebKit/WebKit/commit/19ac18d5d05c20343fddb8a809dca7490b76ef2e
Author: Anne van Kesteren <[email protected]>
Date: 2026-09-18 (Fri, 18 Sep 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/webauthn/createcredential-badargs-sharedarraybuffer.https-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/webauthn/createcredential-badargs-sharedarraybuffer.https.html
A
LayoutTests/imported/w3c/web-platform-tests/webauthn/getcredential-badargs-sharedarraybuffer.https-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/webauthn/getcredential-badargs-sharedarraybuffer.https.html
M LayoutTests/imported/w3c/web-platform-tests/webauthn/w3c-import.log
M Source/WebCore/bindings/js/JSDOMConvertUnion.h
Log Message:
-----------
IDLBufferSource should not accept SharedArrayBuffer
https://bugs.webkit.org/show_bug.cgi?id=324537
Reviewed by Youenn Fablet.
IDLBufferSource is the compile-time type for a BufferSource that is not
[AllowShared], but its converter wrapped both union members in
IDLAllowSharedAdaptor. So the WebAuthn dictionary members that opt into it with
[OverrideIDLType] took a SharedArrayBuffer, or a view onto one, instead of
throwing a TypeError.
[AllowShared] BufferSource is spelled
IDLAllowSharedAdaptor<IDLUnion<IDLArrayBufferView, IDLArrayBuffer>> and keeps
its own converter, so it is unaffected.
Tests:
imported/w3c/web-platform-tests/webauthn/createcredential-badargs-sharedarraybuffer.https.html
imported/w3c/web-platform-tests/webauthn/getcredential-badargs-sharedarraybuffer.https.html
Tests upstream: https://github.com/web-platform-tests/wpt/pull/62788
Canonical link: https://commits.webkit.org/321386@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
